Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add kubernetes test on connection pool behaviour #4196

Merged
merged 9 commits into from
Jan 20, 2022

Conversation

alaeddine-13
Copy link
Contributor

closes: #4147

@github-actions github-actions bot added size/M area/testing This issue/PR affects testing labels Jan 20, 2022
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #4196 (ba9efc8) into master (def0a12) will increase coverage by 0.50%.
The diff coverage is 79.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4196      +/-   ##
==========================================
+ Coverage   86.53%   87.03%   +0.50%     
==========================================
  Files         118      114       -4     
  Lines        8338     8302      -36     
==========================================
+ Hits         7215     7226      +11     
+ Misses       1123     1076      -47     
Flag Coverage Δ
daemon 42.50% <53.14%> (+0.39%) ⬆️
jina 86.78% <79.37%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 70.58% <ø> (ø)
jina/jaml/parsers/base.py 60.00% <0.00%> (ø)
jina/jaml/parsers/default/v1.py 0.00% <0.00%> (-76.20%) ⬇️
jina/types/request/__init__.py 100.00% <ø> (ø)
jina/proto/jina_pb2.py 58.10% <3.33%> (ø)
jina/clients/mixin.py 90.47% <25.00%> (ø)
jina/parsers/helper.py 45.18% <50.00%> (-0.34%) ⬇️
jina/clients/base/helper.py 85.48% <60.00%> (-0.24%) ⬇️
jina/clients/request/__init__.py 73.91% <66.66%> (ø)
jina/types/mixin.py 70.83% <66.66%> (-8.34%) ⬇️
... and 144 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4960ae9...ba9efc8. Read the comment docs.

JoanFM
JoanFM previously approved these changes Jan 20, 2022
@github-actions
Copy link

github-actions bot commented Jan 20, 2022

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 872, delta to last 2 avg.: -36%
  • 🐎🐎🐎🐎 query QPS at 45, delta to last 2 avg.: +65%
  • 🐎🐎🐎🐎 avg flow time within 1.7432 seconds, delta to last 2 avg.: +15%
  • 😶 import jina within 0.4023 seconds, delta to last 2 avg.: +1%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 872 45 1.7432 0.4023
2.6.4 1443 28 1.4989 0.3796
2.6.3 1320 25 1.5141 0.4147

Backed by latency-tracking. Further commits will update this comment.

@github-actions github-actions bot added area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Jan 20, 2022
@github-actions github-actions bot removed area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Jan 20, 2022
@alaeddine-13 alaeddine-13 marked this pull request as ready for review January 20, 2022 23:08
@JoanFM JoanFM merged commit 305f4c3 into master Jan 20, 2022
@JoanFM JoanFM deleted the test-k8s-connection-pool branch January 20, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/M size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create test for disabling K8sGrpcConnectionPool
2 participants