Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove fluentd and identity arg #4199

Merged
merged 9 commits into from
Jan 24, 2022
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jan 20, 2022

No description provided.

@JoanFM JoanFM changed the title Remove fluent from default refactor: remove fluentd Jan 20, 2022
@github-actions
Copy link

github-actions bot commented Jan 20, 2022

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1086, delta to last 2 avg.: -11%
  • 🐎🐎🐎🐎 query QPS at 54, delta to last 2 avg.: +153%
  • 🐎🐎 avg flow time within 1.631 seconds, delta to last 2 avg.: +6%
  • 🐢🐢 import jina within 0.2969 seconds, delta to last 2 avg.: -36%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1086 54 1.631 0.2969
2.6.4 1330 22 1.4948 0.4235
2.6.3 1129 19 1.5726 0.5132

Backed by latency-tracking. Further commits will update this comment.

@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase area/daemon area/docker This issue/PR affects the docker functionality area/docs This issue/PR affects the docs area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing component/logging component/resource labels Jan 20, 2022
@JoanFM JoanFM changed the title refactor: remove fluentd refactor: remove fluentd and identity parameter Jan 20, 2022
@JoanFM JoanFM changed the title refactor: remove fluentd and identity parameter refactor: remove fluentd and identity arg Jan 20, 2022
@JoanFM JoanFM closed this Jan 20, 2022
@JoanFM JoanFM reopened this Jan 20, 2022
@github-actions github-actions bot added the area/cli This issue/PR affects the command line interface label Jan 20, 2022
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #4199 (1f04634) into master (dfbabd5) will increase coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4199      +/-   ##
==========================================
+ Coverage   87.10%   87.37%   +0.27%     
==========================================
  Files         114      114              
  Lines        8304     8269      -35     
==========================================
- Hits         7233     7225       -8     
+ Misses       1071     1044      -27     
Flag Coverage Δ
daemon 42.30% <100.00%> (-0.25%) ⬇️
jina 86.56% <100.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 70.58% <ø> (ø)
jina/orchestrate/flow/base.py 90.98% <ø> (-0.14%) ⬇️
jina/orchestrate/peas/jinad.py 92.18% <ø> (-1.25%) ⬇️
jina/logging/logger.py 91.76% <100.00%> (-1.10%) ⬇️
jina/orchestrate/peas/__init__.py 90.00% <100.00%> (ø)
jina/orchestrate/pods/__init__.py 80.72% <100.00%> (+2.87%) ⬆️
jina/parsers/flow.py 100.00% <100.00%> (ø)
jina/parsers/peapods/base.py 100.00% <100.00%> (ø)
jina/serve/networking.py 83.73% <0.00%> (+0.27%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfbabd5...1f04634. Read the comment docs.

@numb3r3
Copy link
Member

numb3r3 commented Jan 24, 2022

After this PR, how to enable fluentd in Jina?

@JoanFM JoanFM marked this pull request as ready for review January 24, 2022 13:55
@JoanFM JoanFM requested a review from hanxiao as a code owner January 24, 2022 13:55
@JoanFM JoanFM merged commit 066fb0b into master Jan 24, 2022
@JoanFM JoanFM deleted the remove-fluent-from-default branch January 24, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/daemon area/docker This issue/PR affects the docker functionality area/docs This issue/PR affects the docs area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing component/logging component/resource size/L size/M size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants