Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove docarray proto from tests and makedocs #4200

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jan 20, 2022

No description provided.

@JoanFM JoanFM changed the title refactor: small docarray proto refactor: remove docarray proto Jan 20, 2022
@JoanFM JoanFM changed the title refactor: remove docarray proto refactor: remove docarray proto from tests and makedocs Jan 20, 2022
@JoanFM JoanFM linked an issue Jan 20, 2022 that may be closed by this pull request
@github-actions github-actions bot added size/S area/docs This issue/PR affects the docs area/testing This issue/PR affects testing labels Jan 20, 2022
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #4200 (de22589) into master (21e5daf) will increase coverage by 1.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4200      +/-   ##
==========================================
+ Coverage   86.25%   87.46%   +1.20%     
==========================================
  Files         114      114              
  Lines        8302     8302              
==========================================
+ Hits         7161     7261     +100     
+ Misses       1141     1041     -100     
Flag Coverage Δ
daemon 42.49% <ø> (ø)
jina 86.66% <ø> (+7.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/jaml/__init__.py 95.47% <0.00%> (+0.41%) ⬆️
jina/orchestrate/pods/config/docker_compose.py 100.00% <0.00%> (+0.53%) ⬆️
jina/helper.py 81.50% <0.00%> (+0.85%) ⬆️
jina/serve/runtimes/gateway/http/app.py 92.04% <0.00%> (+1.13%) ⬆️
jina/jaml/parsers/flow/v1.py 98.24% <0.00%> (+1.75%) ⬆️
jina/clients/base/http.py 96.07% <0.00%> (+1.96%) ⬆️
...strate/pods/config/k8slib/kubernetes_deployment.py 53.19% <0.00%> (+2.12%) ⬆️
jina/orchestrate/peas/jinad.py 93.43% <0.00%> (+2.18%) ⬆️
jina/jaml/helper.py 85.36% <0.00%> (+2.43%) ⬆️
jina/orchestrate/peas/__init__.py 90.00% <0.00%> (+3.12%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21e5daf...de22589. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 974, delta to last 2 avg.: -35%
  • 🐎🐎🐎🐎 query QPS at 50, delta to last 2 avg.: +66%
  • 🐎🐎 avg flow time within 1.4685 seconds, delta to last 2 avg.: +6%
  • 😶 import jina within 0.3477 seconds, delta to last 2 avg.: -1%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 974 50 1.4685 0.3477
2.6.4 1489 30 1.2889 0.3504
2.6.3 1521 30 1.4634 0.357

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit dde78e3 into master Jan 20, 2022
@JoanFM JoanFM deleted the refactor-small-docarray-proto branch January 20, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs This issue/PR affects the docs area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deploy-to-netlify fails, because docarray proto missing
1 participant