Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flatten proto structure #4212

Merged
merged 1 commit into from
Jan 24, 2022
Merged

fix: flatten proto structure #4212

merged 1 commit into from
Jan 24, 2022

Conversation

jacobowitz
Copy link
Contributor

this should fix the doc generation issue

@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/proto labels Jan 24, 2022
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #4212 (f08fcc6) into master (dfbabd5) will decrease coverage by 7.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4212      +/-   ##
==========================================
- Coverage   87.10%   80.03%   -7.07%     
==========================================
  Files         114      114              
  Lines        8304     8304              
==========================================
- Hits         7233     6646     -587     
- Misses       1071     1658     +587     
Flag Coverage Δ
daemon 42.48% <ø> (-0.07%) ⬇️
jina 76.16% <ø> (-10.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/orchestrate/pods/config/k8s.py 0.00% <0.00%> (-100.00%) ⬇️
jina/checker.py 0.00% <0.00%> (-96.30%) ⬇️
...orchestrate/pods/config/k8slib/kubernetes_tools.py 0.00% <0.00%> (-78.58%) ⬇️
...strate/pods/config/k8slib/kubernetes_deployment.py 0.00% <0.00%> (-53.20%) ⬇️
jina/clients/helper.py 47.50% <0.00%> (-52.50%) ⬇️
jina/importer.py 57.69% <0.00%> (-29.49%) ⬇️
jina/helper.py 62.50% <0.00%> (-19.01%) ⬇️
jina/serve/networking.py 71.27% <0.00%> (-12.20%) ⬇️
jina/parsers/ping.py 88.88% <0.00%> (-11.12%) ⬇️
jina/orchestrate/flow/base.py 80.73% <0.00%> (-10.39%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfbabd5...f08fcc6. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 760, delta to last 2 avg.: -46%
  • 🐎🐎🐎🐎 query QPS at 36, delta to last 2 avg.: +32%
  • 🐎🐎🐎🐎 avg flow time within 1.8131 seconds, delta to last 2 avg.: +29%
  • 🐎🐎🐎🐎 import jina within 0.4234 seconds, delta to last 2 avg.: +14%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 760 36 1.8131 0.4234
2.6.4 1292 22 1.5267 0.3936
2.6.3 1524 32 1.274 0.3434

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit 5b6d2bd into master Jan 24, 2022
@JoanFM JoanFM deleted the fix-proto-structure branch January 24, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/proto size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants