Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add meaningful error on docarray issue #4213

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Conversation

jacobowitz
Copy link
Contributor

Issue #4194 was meant to be fixed by #4203

Unfortunately it did not, because the post install trigger is not happening when installing Jina as a wheel.
I dont see a proper way of working around it, so I changed at least the error message to something more meaningful

@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality labels Jan 24, 2022
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #4213 (e446cb7) into master (5b6d2bd) will increase coverage by 0.48%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4213      +/-   ##
==========================================
+ Coverage   86.38%   86.86%   +0.48%     
==========================================
  Files         114      114              
  Lines        8304     8307       +3     
==========================================
+ Hits         7173     7216      +43     
+ Misses       1131     1091      -40     
Flag Coverage Δ
daemon 42.49% <50.00%> (+<0.01%) ⬆️
jina 86.61% <50.00%> (+7.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 69.31% <50.00%> (-1.28%) ⬇️
jina/serve/networking.py 71.27% <0.00%> (-12.47%) ⬇️
jina/orchestrate/peas/jinad.py 93.43% <0.00%> (-0.73%) ⬇️
jina/jaml/__init__.py 95.47% <0.00%> (+0.41%) ⬆️
jina/orchestrate/pods/config/docker_compose.py 100.00% <0.00%> (+0.53%) ⬆️
jina/helper.py 81.50% <0.00%> (+0.85%) ⬆️
jina/serve/runtimes/gateway/http/app.py 92.13% <0.00%> (+1.12%) ⬆️
jina/jaml/parsers/flow/v1.py 98.24% <0.00%> (+1.75%) ⬆️
jina/clients/base/http.py 96.07% <0.00%> (+1.96%) ⬆️
...strate/pods/config/k8slib/kubernetes_deployment.py 53.19% <0.00%> (+2.12%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b6d2bd...e446cb7. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 815, delta to last 2 avg.: -42%
  • 🐎🐎🐎🐎 query QPS at 43, delta to last 2 avg.: +62%
  • 😶 avg flow time within 1.3676 seconds, delta to last 2 avg.: +5%
  • 😶 import jina within 0.4134 seconds, delta to last 2 avg.: +2%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 815 43 1.3676 0.4134
2.6.4 1478 26 1.4628 0.3845
2.6.3 1340 25 1.1383 0.42

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit a58d866 into master Jan 25, 2022
@hanxiao hanxiao deleted the fix-docarray-error-msg branch January 25, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants