Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace docker id with uids #4217

Merged
merged 1 commit into from
Jan 25, 2022
Merged

fix: replace docker id with uids #4217

merged 1 commit into from
Jan 25, 2022

Conversation

jacobowitz
Copy link
Contributor

the hack to retrieve the container id was too unreliable. I replaced it with some simple uid mechanism. No need to get the actual container id.

@github-actions github-actions bot added size/S area/testing This issue/PR affects testing labels Jan 25, 2022
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #4217 (a6ca2dc) into master (a58d866) will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4217      +/-   ##
==========================================
+ Coverage   86.41%   86.64%   +0.22%     
==========================================
  Files         114      114              
  Lines        8272     8272              
==========================================
+ Hits         7148     7167      +19     
+ Misses       1124     1105      -19     
Flag Coverage Δ
daemon 42.34% <ø> (ø)
jina 84.57% <ø> (-1.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/jaml/parsers/__init__.py 85.71% <0.00%> (-7.15%) ⬇️
.../runtimes/request_handlers/data_request_handler.py 86.31% <0.00%> (-6.32%) ⬇️
jina/clients/__init__.py 84.84% <0.00%> (-6.07%) ⬇️
jina/orchestrate/flow/base.py 85.71% <0.00%> (-5.28%) ⬇️
jina/orchestrate/peas/__init__.py 86.25% <0.00%> (-3.75%) ⬇️
jina/jaml/helper.py 82.92% <0.00%> (-2.44%) ⬇️
jina/serve/runtimes/gateway/http/__init__.py 97.56% <0.00%> (-2.44%) ⬇️
jina/clients/base/http.py 94.11% <0.00%> (-1.97%) ⬇️
jina/jaml/parsers/flow/v1.py 96.49% <0.00%> (-1.76%) ⬇️
jina/orchestrate/peas/jinad.py 90.62% <0.00%> (-1.57%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a58d866...a6ca2dc. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 987, delta to last 2 avg.: -29%
  • 🐎🐎🐎🐎 query QPS at 50, delta to last 2 avg.: +80%
  • 🐎🐎🐎🐎 avg flow time within 1.6938 seconds, delta to last 2 avg.: +40%
  • 🐢🐢 import jina within 0.3439 seconds, delta to last 2 avg.: -13%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 987 50 1.6938 0.3439
2.6.4 1317 26 1.0872 0.424
2.6.3 1474 28 1.3266 0.3677

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit 1b7711d into master Jan 25, 2022
@JoanFM JoanFM deleted the fix-scale-tests branch January 25, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants