Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: rescue docarray in setup" #4219

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Conversation

jacobowitz
Copy link
Contributor

This reverts commit 20d28a8.

Fix does not help for the interesting cases and may have undesirable side effects

@github-actions github-actions bot added size/S area/setup This issue/PR affects setting up Jina labels Jan 25, 2022
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #4219 (6da274a) into master (3cf7017) will decrease coverage by 4.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4219      +/-   ##
==========================================
- Coverage   86.25%   81.43%   -4.83%     
==========================================
  Files         114      114              
  Lines        8272     8272              
==========================================
- Hits         7135     6736     -399     
- Misses       1137     1536     +399     
Flag Coverage Δ
daemon 42.34% <ø> (ø)
jina 77.75% <ø> (-1.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/orchestrate/pods/config/k8s.py 0.00% <0.00%> (-100.00%) ⬇️
...orchestrate/pods/config/k8slib/kubernetes_tools.py 0.00% <0.00%> (-78.58%) ⬇️
jina/orchestrate/peas/jinad.py 26.56% <0.00%> (-64.07%) ⬇️
...strate/pods/config/k8slib/kubernetes_deployment.py 0.00% <0.00%> (-51.07%) ⬇️
jina/serve/networking.py 70.18% <0.00%> (-13.56%) ⬇️
jina/orchestrate/peas/factory.py 88.88% <0.00%> (-7.41%) ⬇️
jina/orchestrate/peas/helper.py 81.42% <0.00%> (-7.15%) ⬇️
jina/orchestrate/flow/base.py 80.95% <0.00%> (-4.77%) ⬇️
jina/orchestrate/peas/__init__.py 85.62% <0.00%> (-1.25%) ⬇️
jina/orchestrate/pods/__init__.py 77.33% <0.00%> (-0.22%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cf7017...6da274a. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 956, delta to last 2 avg.: -28%
  • 🐎🐎🐎🐎 query QPS at 50, delta to last 2 avg.: +99%
  • 🐢🐢 avg flow time within 1.2591 seconds, delta to last 2 avg.: -7%
  • 🐢🐢 import jina within 0.3648 seconds, delta to last 2 avg.: -11%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 956 50 1.2591 0.3648
2.6.4 1128 19 1.6334 0.4727
2.6.3 1546 30 1.0915 0.3542

Backed by latency-tracking. Further commits will update this comment.

@jacobowitz jacobowitz merged commit 5cef964 into master Jan 25, 2022
@jacobowitz jacobowitz deleted the fix-revert-docarray-rescue branch January 25, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/setup This issue/PR affects setting up Jina size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants