feat: use external pods from k8s #4223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/M
area/core
Codecov Report
@@ Coverage Diff @@
## master #4223 +/- ##
==========================================
+ Coverage 85.75% 86.81% +1.06%
==========================================
Files 114 114
Lines 8268 8284 +16
==========================================
+ Hits 7090 7192 +102
+ Misses 1178 1092 -86
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
JoanFM
reviewed
Jan 27, 2022
JoanFM
reviewed
Jan 27, 2022
JoanFM
reviewed
Jan 27, 2022
JoanFM
requested changes
Jan 27, 2022
jacobowitz
force-pushed
the
feat-external-pods-k8s
branch
from
3bf4387
to
098867b
Compare
JoanFM
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #4145
This PR adds the possibility to use external Pods from a Flow in K8s. Before this PR, we would always generate K8s yaml files for the external Pods.
With this change those yamls for the external Pod are no longer generated. Also the Gateway pod address list logic is updated to cater for those external Pods. External Pods always need to be announced to the Gateway. It does not matter if the K8sConnectionPool is used or not. The gateway will always communicate to the head of the external Pod via a fixed address, configured in the Flow.