Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename pod to deployment #4230

Merged
merged 21 commits into from
Feb 4, 2022
Merged

refactor: rename pod to deployment #4230

merged 21 commits into from
Feb 4, 2022

Conversation

jacobowitz
Copy link
Contributor

@jacobowitz jacobowitz commented Feb 1, 2022

Closes #4209

This PR renames Pod to Deployment and Pea to Pod.

@github-actions github-actions bot added size/XL area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/daemon area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/client component/jaml component/logging component/proto component/resource labels Feb 1, 2022
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 30, delta to last 2 avg.: -97%
  • 🐎🐎🐎🐎 query QPS at 36, delta to last 2 avg.: +23%
  • 🐎🐎🐎🐎 avg flow time within 2.1057 seconds, delta to last 2 avg.: +75%
  • 🐎🐎🐎🐎 import jina within 0.4518 seconds, delta to last 2 avg.: +20%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 30 36 2.1057 0.4518
2.6.4 1303 26 1.0647 0.411
2.6.3 1521 32 1.3297 0.3404

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #4230 (6192888) into master (ecaae24) will increase coverage by 0.97%.
The diff coverage is 86.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4230      +/-   ##
==========================================
+ Coverage   86.21%   87.19%   +0.97%     
==========================================
  Files         114      113       -1     
  Lines        8286     8254      -32     
==========================================
+ Hits         7144     7197      +53     
+ Misses       1142     1057      -85     
Flag Coverage Δ
daemon 42.23% <57.39%> (-0.18%) ⬇️
jina 86.93% <86.88%> (+8.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 69.31% <ø> (ø)
jina/checker.py 96.29% <ø> (ø)
jina/clients/mixin.py 90.47% <ø> (ø)
jina/helper.py 81.87% <0.00%> (+0.83%) ⬆️
jina/jaml/parsers/executor/legacy.py 91.17% <ø> (ø)
jina/orchestrate/deployments/config/helper.py 96.15% <ø> (ø)
...rate/deployments/config/k8slib/kubernetes_tools.py 100.00% <ø> (ø)
jina/orchestrate/pods/container_helper.py 73.80% <ø> (ø)
jina/parsers/deprecated.py 83.33% <ø> (ø)
jina/parsers/helper.py 45.18% <ø> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecaae24...6192888. Read the comment docs.

@github-actions github-actions bot added the area/docs This issue/PR affects the docs label Feb 1, 2022
@jacobowitz jacobowitz marked this pull request as ready for review February 2, 2022 11:43
@github-actions
Copy link

github-actions bot commented Feb 3, 2022

📝 Docs are deployed on https://feat-rename-peapod--jina-docs.netlify.app 🎉

@JoanFM JoanFM merged commit 13edc16 into master Feb 4, 2022
@JoanFM JoanFM deleted the feat-rename-peapod branch February 4, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/daemon area/docs This issue/PR affects the docs area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/client component/jaml component/logging component/proto component/resource size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Pods to Deployment and Pea to Pod
3 participants