Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide more parameters from k8s and compose yamls #4242

Merged
merged 6 commits into from
Feb 7, 2022
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Feb 7, 2022

No description provided.

@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase labels Feb 7, 2022
@github-actions github-actions bot added the area/cli This issue/PR affects the command line interface label Feb 7, 2022
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #4242 (2963728) into master (bfd5357) will decrease coverage by 2.98%.
The diff coverage is 97.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4242      +/-   ##
==========================================
- Coverage   87.73%   84.75%   -2.99%     
==========================================
  Files         113      113              
  Lines        8254     8287      +33     
==========================================
- Hits         7242     7024     -218     
- Misses       1012     1263     +251     
Flag Coverage Δ
daemon 42.17% <11.42%> (-0.04%) ⬇️
jina 84.46% <97.14%> (-2.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/parsers/flow.py 100.00% <ø> (ø)
jina/parsers/orchestrate/base.py 100.00% <ø> (ø)
jina/parsers/orchestrate/runtimes/worker.py 100.00% <ø> (ø)
jina/orchestrate/flow/base.py 91.00% <88.88%> (-0.07%) ⬇️
...a/orchestrate/deployments/config/docker_compose.py 100.00% <100.00%> (ø)
jina/orchestrate/deployments/config/helper.py 93.75% <100.00%> (-2.41%) ⬇️
jina/orchestrate/deployments/config/k8s.py 100.00% <100.00%> (ø)
jina/checker.py 0.00% <0.00%> (-96.30%) ⬇️
jina/clients/helper.py 47.50% <0.00%> (-52.50%) ⬇️
jina/importer.py 57.69% <0.00%> (-29.49%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 720642d...2963728. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Latency summary

Current PR yields:

  • 😶 index QPS at 1191, delta to last 2 avg.: +4%
  • 🐎🐎🐎🐎 query QPS at 53, delta to last 2 avg.: +160%
  • 😶 avg flow time within 1.6428 seconds, delta to last 2 avg.: +3%
  • 🐢🐢 import jina within 0.3525 seconds, delta to last 2 avg.: -22%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1191 53 1.6428 0.3525
2.6.4 1140 20 1.5751 0.4575
2.6.3 1149 20 1.6037 0.4551

Backed by latency-tracking. Further commits will update this comment.

@github-actions github-actions bot added area/docs This issue/PR affects the docs component/resource labels Feb 7, 2022
@JoanFM JoanFM closed this Feb 7, 2022
@JoanFM JoanFM reopened this Feb 7, 2022
@JoanFM JoanFM closed this Feb 7, 2022
@JoanFM JoanFM reopened this Feb 7, 2022
@JoanFM JoanFM marked this pull request as ready for review February 7, 2022 14:13
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

📝 Docs are deployed on https://hide-params--jina-docs.netlify.app 🎉

@JoanFM JoanFM merged commit 6e24af6 into master Feb 7, 2022
@JoanFM JoanFM deleted the hide-params branch February 7, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide workspace from to_docker_compose and to_k8s interface Message how to run on k8s after dumping
2 participants