Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change the way parameters are returned from Executors #4243

Merged
merged 13 commits into from
Feb 7, 2022

Conversation

samsja
Copy link
Contributor

@samsja samsja commented Feb 7, 2022

follow up on this PR which is somehow broken on the github side

@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/client labels Feb 7, 2022
@samsja samsja changed the title feat: change the way parameters are returned from Executors part 2 feat: change the way parameters are returned from Executors Feb 7, 2022
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1205, delta to last 2 avg.: -20%
  • 🐎🐎🐎🐎 query QPS at 53, delta to last 2 avg.: +79%
  • 😶 avg flow time within 1.2268 seconds, delta to last 2 avg.: +3%
  • 😶 import jina within 0.3501 seconds, delta to last 2 avg.: -2%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1205 53 1.2268 0.3501
2.6.4 1489 29 1.3256 0.3678
2.6.3 1551 29 1.04 0.3532

Backed by latency-tracking. Further commits will update this comment.

@samsja
Copy link
Contributor Author

samsja commented Feb 7, 2022

the test named test_flow_change_parameters has been deleted because we don't allow anymore to change the parameters within the executors context

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #4243 (ff9c574) into master (d1a0833) will increase coverage by 0.06%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4243      +/-   ##
==========================================
+ Coverage   87.16%   87.23%   +0.06%     
==========================================
  Files         113      113              
  Lines        8254     8286      +32     
==========================================
+ Hits         7195     7228      +33     
+ Misses       1059     1058       -1     
Flag Coverage Δ
daemon 42.11% <23.07%> (-0.08%) ⬇️
jina 86.97% <92.30%> (+1.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/clients/mixin.py 87.03% <75.00%> (-3.44%) ⬇️
.../runtimes/request_handlers/data_request_handler.py 93.91% <100.00%> (+7.59%) ⬆️
jina/serve/networking.py 71.27% <0.00%> (-12.47%) ⬇️
jina/orchestrate/deployments/__init__.py 80.80% <0.00%> (-2.11%) ⬇️
jina/jaml/__init__.py 95.43% <0.00%> (+0.38%) ⬆️
jina/orchestrate/pods/jinad.py 94.57% <0.00%> (+0.77%) ⬆️
jina/helper.py 81.87% <0.00%> (+0.83%) ⬆️
jina/serve/runtimes/gateway/http/app.py 90.80% <0.00%> (+1.14%) ⬆️
jina/jaml/parsers/flow/v1.py 98.24% <0.00%> (+1.75%) ⬆️
jina/clients/base/http.py 96.22% <0.00%> (+1.88%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a0833...ff9c574. Read the comment docs.

@JoanFM JoanFM merged commit 48871dd into master Feb 7, 2022
@JoanFM JoanFM deleted the fix-3946-results-param branch February 7, 2022 14:11
@JoanFM JoanFM linked an issue Feb 7, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/client size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executor: endpoints should merge parameters from shards
2 participants