Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove fluent resources #4244

Merged
merged 1 commit into from
Feb 7, 2022
Merged

fix: remove fluent resources #4244

merged 1 commit into from
Feb 7, 2022

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Feb 7, 2022

No description provided.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase component/resource labels Feb 7, 2022
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #4244 (91315ee) into master (bfd5357) will decrease coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4244      +/-   ##
==========================================
- Coverage   87.73%   87.19%   -0.55%     
==========================================
  Files         113      113              
  Lines        8254     8254              
==========================================
- Hits         7242     7197      -45     
- Misses       1012     1057      +45     
Flag Coverage Δ
daemon 42.20% <ø> (ø)
jina 86.93% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/serve/networking.py 71.27% <0.00%> (-12.47%) ⬇️
jina/orchestrate/pods/jinad.py 93.02% <0.00%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfd5357...91315ee. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 950, delta to last 2 avg.: -41%
  • 🐎🐎🐎🐎 query QPS at 43, delta to last 2 avg.: +41%
  • 🐎🐎🐎🐎 avg flow time within 1.3739 seconds, delta to last 2 avg.: +12%
  • 🐎🐎🐎🐎 import jina within 0.4317 seconds, delta to last 2 avg.: +21%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 950 43 1.3739 0.4317
2.6.4 1696 30 1.0318 0.3538
2.6.3 1558 29 1.417 0.3573

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit 2f0bb10 into master Feb 7, 2022
@JoanFM JoanFM deleted the remove-fluent-resource branch February 7, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/resource size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant