Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error message #4245

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Feb 7, 2022

Pull Request Title

Description

Please describe what your PR is doing and why. Are there any parts which need extra attention during review? Are there any dependencies from other PRs or projcts? Is this a breaking change?

Is this PR ready or work in progress (WIP)? Ready means it can be reviewed and merged from the author's perspective. If the PR is WIP: Make it a draft PR and state open questions and TODO items.

Closes # (issue)

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing labels Feb 7, 2022
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1030, delta to last 2 avg.: -23%
  • 🐎🐎🐎🐎 query QPS at 42, delta to last 2 avg.: +57%
  • 😶 avg flow time within 1.3231 seconds, delta to last 2 avg.: +0%
  • 🐢🐢 import jina within 0.353 seconds, delta to last 2 avg.: -17%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1030 42 1.3231 0.353
2.6.4 1399 27 1.5293 0.3833
2.6.3 1293 25 1.1175 0.4693

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #4245 (dfea68e) into master (bfd5357) will decrease coverage by 0.44%.
The diff coverage is 95.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4245      +/-   ##
==========================================
- Coverage   87.73%   87.29%   -0.45%     
==========================================
  Files         113      113              
  Lines        8254     8304      +50     
==========================================
+ Hits         7242     7249       +7     
- Misses       1012     1055      +43     
Flag Coverage Δ
daemon 42.10% <15.38%> (-0.11%) ⬇️
jina 87.04% <95.60%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/parsers/flow.py 100.00% <ø> (ø)
jina/parsers/orchestrate/base.py 100.00% <ø> (ø)
jina/parsers/orchestrate/runtimes/worker.py 100.00% <ø> (ø)
jina/clients/mixin.py 87.03% <75.00%> (-3.44%) ⬇️
jina/orchestrate/flow/base.py 91.00% <88.88%> (-0.07%) ⬇️
jina/excepts.py 100.00% <100.00%> (ø)
...a/orchestrate/deployments/config/docker_compose.py 100.00% <100.00%> (ø)
jina/orchestrate/deployments/config/helper.py 98.27% <100.00%> (+2.12%) ⬆️
jina/orchestrate/deployments/config/k8s.py 100.00% <100.00%> (ø)
.../runtimes/request_handlers/data_request_handler.py 93.91% <100.00%> (+1.28%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e24af6...dfea68e. Read the comment docs.

@JoanFM JoanFM force-pushed the good-error-message-k8s-docker-compose branch from 9bde695 to 98f7fe0 Compare February 7, 2022 16:46
@JoanFM JoanFM force-pushed the good-error-message-k8s-docker-compose branch from 98f7fe0 to dfea68e Compare February 8, 2022 06:58
@JoanFM JoanFM merged commit f1a3bb9 into master Feb 8, 2022
@JoanFM JoanFM deleted the good-error-message-k8s-docker-compose branch February 8, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant