-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adapt to 3.0 #4254
docs: adapt to 3.0 #4254
Conversation
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest running the whole doc through grammarly to pick up anything I may have missed
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
* docs: fix kubernetes docs * docs: add caution
Codecov Report
@@ Coverage Diff @@
## master #4254 +/- ##
==========================================
- Coverage 87.73% 78.11% -9.63%
==========================================
Files 113 114 +1
Lines 8254 8324 +70
==========================================
- Hits 7242 6502 -740
- Misses 1012 1822 +810
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
📝 Docs are deployed on https://docs3_0--jina-docs.netlify.app 🎉 |
1 similar comment
📝 Docs are deployed on https://docs3_0--jina-docs.netlify.app 🎉 |
📝 Docs are deployed on https://docs3_0--jina-docs.netlify.app 🎉 |
1 similar comment
📝 Docs are deployed on https://docs3_0--jina-docs.netlify.app 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style
Co-authored-by: CatStark <susana.guzman@jina.ai>
Co-authored-by: CatStark <susana.guzman@jina.ai>
@@ -1,8 +1,7 @@ | |||
from jina import Executor, DocumentArray, requests | |||
from jina import Executor, requests, DocumentArray |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we want to import DocumentArray
from docarray
📝 Docs are deployed on https://docs3_0--jina-docs.netlify.app 🎉 |
1 similar comment
📝 Docs are deployed on https://docs3_0--jina-docs.netlify.app 🎉 |
Pull Request Title
Description
Please describe what your PR is doing and why. Are there any parts which need extra attention during review? Are there any dependencies from other PRs or projcts? Is this a breaking change?
Is this PR ready or work in progress (WIP)? Ready means it can be reviewed and merged from the author's perspective. If the PR is WIP: Make it a draft PR and state open questions and TODO items.
Closes # (issue)