Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hub): add --verbose option to "jina hub push" CLI #4278

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

delgermurun
Copy link
Contributor

@delgermurun delgermurun commented Feb 11, 2022

@github-actions github-actions bot added size/S area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase labels Feb 11, 2022
@github-actions
Copy link

github-actions bot commented Feb 11, 2022

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 888, delta to last 2 avg.: -31%
  • 🐎🐎🐎🐎 query QPS at 36, delta to last 2 avg.: +52%
  • 🐎🐎🐎🐎 avg flow time within 1.8397 seconds, delta to last 2 avg.: +16%
  • 🐎🐎 import jina within 0.4469 seconds, delta to last 2 avg.: +9%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 888 36 1.8397 0.4469
2.6.4 1215 23 1.6071 0.4452
2.6.3 1392 24 1.5498 0.3678

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #4278 (bbd0c49) into master (bfd5357) will decrease coverage by 0.07%.
The diff coverage is 88.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4278      +/-   ##
==========================================
- Coverage   87.73%   87.66%   -0.08%     
==========================================
  Files         113      113              
  Lines        8254     8311      +57     
==========================================
+ Hits         7242     7286      +44     
- Misses       1012     1025      +13     
Flag Coverage Δ
daemon 42.01% <13.51%> (-0.20%) ⬇️
jina 87.41% <88.51%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/parsers/flow.py 100.00% <ø> (ø)
jina/parsers/orchestrate/base.py 100.00% <ø> (ø)
jina/parsers/orchestrate/runtimes/worker.py 100.00% <ø> (ø)
jina/serve/networking.py 71.27% <ø> (-12.47%) ⬇️
jina/clients/mixin.py 87.03% <75.00%> (-3.44%) ⬇️
jina/hubble/hubio.py 86.15% <75.00%> (+5.98%) ⬆️
jina/orchestrate/flow/base.py 91.00% <88.88%> (-0.07%) ⬇️
jina/excepts.py 100.00% <100.00%> (ø)
jina/helper.py 81.90% <100.00%> (+0.03%) ⬆️
jina/jaml/__init__.py 94.29% <100.00%> (-1.15%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b3470e...bbd0c49. Read the comment docs.

@delgermurun delgermurun marked this pull request as ready for review February 11, 2022 14:53
Copy link
Member

@mapleeit mapleeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Require a unit test to cover this case.

@github-actions github-actions bot added the area/testing This issue/PR affects testing label Feb 14, 2022
@delgermurun
Copy link
Contributor Author

Require a unit test to cover this case.

Added checks on unit tests

@mapleeit mapleeit requested a review from JoanFM February 14, 2022 06:17
@mapleeit mapleeit merged commit a5935ab into master Feb 14, 2022
@mapleeit mapleeit deleted the feat-hub-verbose-option branch February 14, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants