Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helloworld): dump before closing #4320

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Feb 14, 2022

No description provided.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels Feb 14, 2022
@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1199, delta to last 2 avg.: -21%
  • 🐎🐎🐎🐎 query QPS at 51, delta to last 2 avg.: +62%
  • 😶 avg flow time within 1.2057 seconds, delta to last 2 avg.: +2%
  • 🐢🐢 import jina within 0.3245 seconds, delta to last 2 avg.: -6%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1199 51 1.2057 0.3245
2.6.4 1531 29 1.0361 0.3542
2.6.3 1536 32 1.3263 0.3408

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #4320 (906d9f1) into master (bfd5357) will decrease coverage by 0.01%.
The diff coverage is 89.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4320      +/-   ##
==========================================
- Coverage   87.73%   87.72%   -0.02%     
==========================================
  Files         113      113              
  Lines        8254     8320      +66     
==========================================
+ Hits         7242     7299      +57     
- Misses       1012     1021       +9     
Flag Coverage Δ
daemon 42.04% <12.57%> (-0.17%) ⬇️
jina 87.47% <89.30%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/parsers/flow.py 100.00% <ø> (ø)
jina/parsers/orchestrate/base.py 100.00% <ø> (ø)
jina/parsers/orchestrate/runtimes/worker.py 100.00% <ø> (ø)
jina/serve/networking.py 71.27% <ø> (-12.47%) ⬇️
jina/clients/mixin.py 87.03% <75.00%> (-3.44%) ⬇️
jina/hubble/hubio.py 86.15% <75.00%> (+5.98%) ⬆️
jina/orchestrate/flow/base.py 91.00% <88.88%> (-0.07%) ⬇️
jina/excepts.py 100.00% <100.00%> (ø)
jina/helloworld/multimodal/app.py 87.50% <100.00%> (+0.70%) ⬆️
jina/helloworld/multimodal/my_executors.py 97.31% <100.00%> (+0.11%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb95e4...906d9f1. Read the comment docs.

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@JoanFM JoanFM merged commit 23dd1f3 into master Feb 15, 2022
@JoanFM JoanFM deleted the fix-hello-multimodal-windows branch February 15, 2022 09:06
samsja pushed a commit that referenced this pull request Feb 15, 2022
samsja pushed a commit that referenced this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants