Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the legacy docaary GA script #4325

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

nan-wang
Copy link
Member

Pull Request Title

Description

Please describe what your PR is doing and why. Are there any parts which need extra attention during review? Are there any dependencies from other PRs or projcts? Is this a breaking change?

Is this PR ready or work in progress (WIP)? Ready means it can be reviewed and merged from the author's perspective. If the PR is WIP: Make it a draft PR and state open questions and TODO items.

Closes # (issue)

@github-actions github-actions bot added size/XS area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Feb 15, 2022
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #4325 (b93c25a) into master (bfd5357) will decrease coverage by 0.07%.
The diff coverage is 88.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4325      +/-   ##
==========================================
- Coverage   87.73%   87.66%   -0.08%     
==========================================
  Files         113      113              
  Lines        8254     8311      +57     
==========================================
+ Hits         7242     7286      +44     
- Misses       1012     1025      +13     
Flag Coverage Δ
daemon 42.04% <13.51%> (-0.17%) ⬇️
jina 87.41% <88.51%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/parsers/flow.py 100.00% <ø> (ø)
jina/parsers/orchestrate/base.py 100.00% <ø> (ø)
jina/parsers/orchestrate/runtimes/worker.py 100.00% <ø> (ø)
jina/serve/networking.py 71.27% <ø> (-12.47%) ⬇️
jina/clients/mixin.py 87.03% <75.00%> (-3.44%) ⬇️
jina/hubble/hubio.py 86.15% <75.00%> (+5.98%) ⬆️
jina/orchestrate/flow/base.py 91.00% <88.88%> (-0.07%) ⬇️
jina/excepts.py 100.00% <100.00%> (ø)
jina/helper.py 81.90% <100.00%> (+0.03%) ⬆️
jina/jaml/__init__.py 94.29% <100.00%> (-1.15%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb95e4...b93c25a. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 935, delta to last 2 avg.: -35%
  • 🐎🐎🐎🐎 query QPS at 39, delta to last 2 avg.: +30%
  • 🐎🐎🐎🐎 avg flow time within 1.7939 seconds, delta to last 2 avg.: +36%
  • 🐎🐎🐎🐎 import jina within 0.4179 seconds, delta to last 2 avg.: +15%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 935 39 1.7939 0.4179
2.6.4 1389 27 1.334 0.3859
2.6.3 1489 31 1.3034 0.3398

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 770a724 into master Feb 15, 2022
@hanxiao hanxiao deleted the chore-disable-docarray-release-1 branch February 15, 2022 07:45
samsja pushed a commit that referenced this pull request Feb 15, 2022
samsja pushed a commit that referenced this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants