Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix flow plot #4336

Merged
merged 2 commits into from
Feb 15, 2022
Merged

fix: fix flow plot #4336

merged 2 commits into from
Feb 15, 2022

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Feb 15, 2022

No description provided.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels Feb 15, 2022
Co-authored-by: Han Xiao <artex.xh@gmail.com>
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #4336 (3f9a038) into master (bfd5357) will decrease coverage by 1.50%.
The diff coverage is 85.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4336      +/-   ##
==========================================
- Coverage   87.73%   86.23%   -1.51%     
==========================================
  Files         113      113              
  Lines        8254     8316      +62     
==========================================
- Hits         7242     7171      -71     
- Misses       1012     1145     +133     
Flag Coverage Δ
daemon 42.01% <12.04%> (-0.20%) ⬇️
jina 85.34% <85.54%> (-1.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/parsers/flow.py 100.00% <ø> (ø)
jina/parsers/orchestrate/base.py 100.00% <ø> (ø)
jina/parsers/orchestrate/runtimes/worker.py 100.00% <ø> (ø)
jina/serve/networking.py 71.27% <ø> (-12.47%) ⬇️
jina/orchestrate/flow/base.py 75.83% <55.55%> (-15.23%) ⬇️
jina/clients/mixin.py 87.03% <75.00%> (-3.44%) ⬇️
jina/hubble/hubio.py 86.15% <75.00%> (+5.98%) ⬆️
...a/orchestrate/deployments/config/docker_compose.py 99.43% <80.00%> (-0.57%) ⬇️
jina/orchestrate/deployments/config/k8s.py 99.38% <80.00%> (-0.62%) ⬇️
jina/orchestrate/deployments/config/helper.py 94.82% <93.75%> (-1.33%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23dd1f3...3f9a038. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 15, 2022

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 837, delta to last 2 avg.: -45%
  • 🐎🐎 query QPS at 34, delta to last 2 avg.: +8%
  • 🐎🐎🐎🐎 avg flow time within 1.8959 seconds, delta to last 2 avg.: +33%
  • 🐎🐎🐎🐎 import jina within 0.4715 seconds, delta to last 2 avg.: +34%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 837 34 1.8959 0.4715
2.6.4 1528 32 1.3526 0.3519
2.6.3 1528 30 1.49 0.3513

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit f55ec04 into master Feb 15, 2022
@hanxiao hanxiao deleted the fix-flow-plot-2 branch February 15, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants