Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return responses #4343

Merged
merged 6 commits into from
Feb 15, 2022
Merged

fix: return responses #4343

merged 6 commits into from
Feb 15, 2022

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Feb 15, 2022

No description provided.

@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase component/client labels Feb 15, 2022
@JoanFM JoanFM closed this Feb 15, 2022
@JoanFM JoanFM reopened this Feb 15, 2022
@github-actions github-actions bot added size/S area/cli This issue/PR affects the command line interface labels Feb 15, 2022
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #4343 (19d77c6) into master (07e2ef0) will increase coverage by 0.52%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4343      +/-   ##
==========================================
+ Coverage   87.19%   87.72%   +0.52%     
==========================================
  Files         114      114              
  Lines        8324     8324              
==========================================
+ Hits         7258     7302      +44     
+ Misses       1066     1022      -44     
Flag Coverage Δ
daemon 42.05% <0.00%> (+0.03%) ⬆️
jina 87.46% <100.00%> (+7.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/clients/__init__.py 90.90% <ø> (+6.06%) ⬆️
jina/orchestrate/flow/base.py 91.00% <ø> (+5.16%) ⬆️
jina/parsers/client.py 100.00% <ø> (ø)
jina/clients/mixin.py 88.88% <100.00%> (+1.85%) ⬆️
jina/serve/networking.py 71.27% <0.00%> (-12.47%) ⬇️
jina/orchestrate/pods/jinad.py 93.02% <0.00%> (-0.78%) ⬇️
jina/jaml/__init__.py 94.29% <0.00%> (+0.38%) ⬆️
...a/orchestrate/deployments/config/docker_compose.py 100.00% <0.00%> (+0.56%) ⬆️
jina/orchestrate/deployments/config/k8s.py 100.00% <0.00%> (+0.61%) ⬆️
jina/helper.py 81.90% <0.00%> (+0.83%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07e2ef0...19d77c6. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 15, 2022

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 977, delta to last 2 avg.: -21%
  • 🐎🐎🐎🐎 query QPS at 44, delta to last 2 avg.: +18%
  • 🐎🐎 avg flow time within 1.6747 seconds, delta to last 2 avg.: +7%
  • 🐎🐎 import jina within 0.4163 seconds, delta to last 2 avg.: +6%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 977 44 1.6747 0.4163
2.7.0 978 44 1.7921 0.422
2.6.4 1519 30 1.3131 0.3577

Backed by latency-tracking. Further commits will update this comment.

@github-actions github-actions bot added size/M area/testing This issue/PR affects testing labels Feb 15, 2022
@JoanFM JoanFM merged commit 2efe175 into master Feb 15, 2022
@JoanFM JoanFM deleted the return-responses branch February 15, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/client size/M size/S size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants