-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adjust docs to new .post() behaviour #4344
Conversation
18cbde8
to
63b665b
Compare
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure that request_size
parameter is explained and considered also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also explain the return_responses
or we should not? Also we are missing docs about the Response
object right?
Co-authored-by: Joan Fontanals <joan.martinez@jina.ai>
967aed8
to
4056b52
Compare
It is explained under 'returning results from .post()', does it need more explanation?
I need to change that, it should say |
It needs to be clear what can be found in |
f5a9b97
to
68d3f90
Compare
|
||
There also exists an async version of the Python Client so that it can easily be used from an `asyncio` context. | ||
|
||
While the standard `Client` is also asynchronous under the hood, its async version exposes this fact to the outside world, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is meant by this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would mention, it allows to asyncrhonously iterate over responses as they come
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is meant by this?
That the async version doesn't hide its async-ness, unlike the normal client. To be honest, I don't know all the details about this async client myself, i just kept this more or less unchanged from Tobi's version. Changed it slightly, let me know if it makes more sense to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise feel free to suggest and apply changes yourself of course
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jacobowitz what is meant with client also being async?
📝 Docs are deployed on https://docs-post-return--jina-docs.netlify.app 🎉 |
No description provided.