Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: template proper import #4345

Merged
merged 1 commit into from
Feb 15, 2022
Merged

fix: template proper import #4345

merged 1 commit into from
Feb 15, 2022

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Feb 15, 2022

No description provided.

@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase component/resource labels Feb 15, 2022
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #4345 (52013d5) into master (aebabad) will decrease coverage by 0.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4345      +/-   ##
==========================================
- Coverage   88.35%   87.67%   -0.69%     
==========================================
  Files         114      114              
  Lines        8324     8324              
==========================================
- Hits         7355     7298      -57     
- Misses        969     1026      +57     
Flag Coverage Δ
daemon 41.95% <ø> (-0.09%) ⬇️
jina 87.42% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/clients/base/grpc.py 59.09% <0.00%> (-20.46%) ⬇️
jina/serve/networking.py 71.27% <0.00%> (-12.47%) ⬇️
jina/orchestrate/deployments/config/helper.py 94.82% <0.00%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aebabad...52013d5. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐎🐎 index QPS at 1195, delta to last 2 avg.: +9%
  • 🐎🐎🐎🐎 query QPS at 55, delta to last 2 avg.: +79%
  • 🐎🐎 avg flow time within 1.5798 seconds, delta to last 2 avg.: +7%
  • 🐢🐢 import jina within 0.3332 seconds, delta to last 2 avg.: -23%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1195 55 1.5798 0.3332
2.7.0 952 39 1.8211 0.4382
2.6.4 1235 21 1.107 0.4365

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit 22f0653 into master Feb 15, 2022
@JoanFM JoanFM deleted the template-import-docarray branch February 15, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/resource size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant