Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sandbox after push #4349

Merged
merged 1 commit into from
Feb 15, 2022
Merged

feat: add sandbox after push #4349

merged 1 commit into from
Feb 15, 2022

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Feb 15, 2022

image

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels Feb 15, 2022
@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1016, delta to last 2 avg.: -14%
  • 🐎🐎🐎🐎 query QPS at 45, delta to last 2 avg.: +28%
  • 🐎🐎 avg flow time within 1.6087 seconds, delta to last 2 avg.: +10%
  • 🐎🐎 import jina within 0.4251 seconds, delta to last 2 avg.: +8%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1016 45 1.6087 0.4251
2.7.0 1020 46 1.3215 0.4141
2.6.4 1368 23 1.5965 0.3731

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #4349 (864f9b7) into master (22f0653) will decrease coverage by 9.48%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4349      +/-   ##
==========================================
- Coverage   87.51%   78.03%   -9.49%     
==========================================
  Files         114      114              
  Lines        8324     8325       +1     
==========================================
- Hits         7285     6496     -789     
- Misses       1039     1829     +790     
Flag Coverage Δ
daemon 42.03% <0.00%> (-0.03%) ⬇️
jina 77.10% <100.00%> (-8.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/clients/mixin.py 89.09% <100.00%> (+0.20%) ⬆️
jina/hubble/hubio.py 86.15% <100.00%> (ø)
...rate/deployments/config/k8slib/kubernetes_tools.py 0.00% <0.00%> (-100.00%) ⬇️
...a/orchestrate/deployments/config/docker_compose.py 0.00% <0.00%> (-99.44%) ⬇️
jina/orchestrate/deployments/config/k8s.py 0.00% <0.00%> (-99.39%) ⬇️
jina/checker.py 0.00% <0.00%> (-96.30%) ⬇️
jina/orchestrate/deployments/config/helper.py 0.00% <0.00%> (-94.83%) ⬇️
...deployments/config/k8slib/kubernetes_deployment.py 0.00% <0.00%> (-53.20%) ⬇️
jina/clients/helper.py 47.50% <0.00%> (-52.50%) ⬇️
jina/importer.py 57.69% <0.00%> (-29.49%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae6df58...864f9b7. Read the comment docs.

@hanxiao hanxiao merged commit c07f3c1 into master Feb 15, 2022
@hanxiao hanxiao deleted the feat-show-sandbox-dialog branch February 15, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant