Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up extra-requirements #4416

Merged
merged 3 commits into from Mar 1, 2022
Merged

Conversation

nan-wang
Copy link
Member

Pull Request Title

Description

clean up the legacy dependency.

Closes # (issue)

@nan-wang nan-wang marked this pull request as draft February 27, 2022 01:43
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/setup This issue/PR affects setting up Jina labels Feb 27, 2022
@github-actions
Copy link

github-actions bot commented Feb 27, 2022

Latency summary

Current PR yields:

  • 😶 index QPS at 1164, delta to last 2 avg.: +2%
  • 🐢🐢 query QPS at 44, delta to last 2 avg.: -7%
  • 🐢🐢 avg flow time within 1.2459 seconds, delta to last 2 avg.: -17%
  • 😶 import jina within 0.355 seconds, delta to last 2 avg.: +0%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1164 44 1.2459 0.355
3.0.3 1144 45 1.4439 0.3544
3.0.2 1129 49 1.5659 0.357

Backed by latency-tracking. Further commits will update this comment.

@nan-wang nan-wang marked this pull request as ready for review February 28, 2022 03:05
jina/__init__.py Outdated
@@ -143,7 +143,6 @@ def _warning_on_one_line(message, category, filename, lineno, *args, **kwargs):
JINA_GLOBAL.scipy_installed = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest are also not needed right?

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #4416 (792a74c) into master (3483943) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4416      +/-   ##
==========================================
+ Coverage   87.56%   87.66%   +0.10%     
==========================================
  Files         114      114              
  Lines        8314     8310       -4     
==========================================
+ Hits         7280     7285       +5     
+ Misses       1034     1025       -9     
Flag Coverage Δ
daemon 41.85% <50.00%> (-0.04%) ⬇️
jina 87.41% <100.00%> (+2.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 67.46% <100.00%> (-1.85%) ⬇️
jina/orchestrate/deployments/config/k8s.py 100.00% <100.00%> (+0.61%) ⬆️
jina/serve/networking.py 71.27% <0.00%> (-12.47%) ⬇️
jina/orchestrate/pods/jinad.py 93.02% <0.00%> (-0.78%) ⬇️
jina/jaml/__init__.py 94.29% <0.00%> (+0.38%) ⬆️
...a/orchestrate/deployments/config/docker_compose.py 100.00% <0.00%> (+0.56%) ⬆️
jina/helper.py 81.90% <0.00%> (+0.83%) ⬆️
jina/serve/runtimes/gateway/http/app.py 90.80% <0.00%> (+1.14%) ⬆️
jina/orchestrate/pods/__init__.py 90.62% <0.00%> (+1.25%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7bb4fc...792a74c. Read the comment docs.

@JoanFM JoanFM merged commit 98cb170 into master Mar 1, 2022
@JoanFM JoanFM deleted the chore-clean-requirements-220227 branch March 1, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/setup This issue/PR affects setting up Jina component/resource size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants