Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update codeowners #4423

Merged
merged 1 commit into from Mar 1, 2022
Merged

chore: update codeowners #4423

merged 1 commit into from Mar 1, 2022

Conversation

nan-wang
Copy link
Member

@nan-wang nan-wang commented Mar 1, 2022

Pull Request Title

Description

update code owners to prevent the incident in #4390

Closes # (issue)

@github-actions github-actions bot added size/XS area/housekeeping This issue/PR is housekeeping labels Mar 1, 2022
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #4423 (d930ba9) into master (d1fb4c3) will increase coverage by 0.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4423      +/-   ##
==========================================
+ Coverage   87.04%   87.63%   +0.58%     
==========================================
  Files         114      114              
  Lines        8315     8315              
==========================================
+ Hits         7238     7287      +49     
+ Misses       1077     1028      -49     
Flag Coverage Δ
daemon 41.88% <ø> (-0.02%) ⬇️
jina 87.38% <ø> (+7.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/serve/networking.py 71.27% <0.00%> (-12.20%) ⬇️
jina/jaml/__init__.py 94.29% <0.00%> (+0.38%) ⬆️
...a/orchestrate/deployments/config/docker_compose.py 100.00% <0.00%> (+0.56%) ⬆️
jina/orchestrate/deployments/config/k8s.py 100.00% <0.00%> (+0.61%) ⬆️
jina/helper.py 81.90% <0.00%> (+0.83%) ⬆️
jina/serve/runtimes/gateway/http/app.py 90.80% <0.00%> (+1.14%) ⬆️
jina/orchestrate/pods/jinad.py 92.24% <0.00%> (+1.55%) ⬆️
jina/jaml/parsers/flow/v1.py 98.24% <0.00%> (+1.75%) ⬆️
.../runtimes/request_handlers/data_request_handler.py 93.80% <0.00%> (+1.76%) ⬆️
jina/clients/base/http.py 96.22% <0.00%> (+1.88%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93d2efb...d930ba9. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1165, delta to last 2 avg.: +26%
  • 🐎🐎🐎🐎 query QPS at 48, delta to last 2 avg.: +27%
  • 😶 avg flow time within 1.6388 seconds, delta to last 2 avg.: +5%
  • 🐢🐢 import jina within 0.3391 seconds, delta to last 2 avg.: -25%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1165 48 1.6388 0.3391
3.0.3 860 34 1.7322 0.4962
3.0.2 976 40 1.3769 0.4148

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit b226479 into master Mar 1, 2022
@JoanFM JoanFM deleted the chore-update-codeowners-20220301 branch March 1, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/housekeeping This issue/PR is housekeeping size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants