Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 8080 as default gateway port in k8s #4605

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Conversation

jacobowitz
Copy link
Contributor

@jacobowitz jacobowitz commented Apr 12, 2022

8080 as default gateway port in k8s

Description

In K8s all Pods should use 8080 as the default port (expect monitoring and uses_before/uses_after). At the moment the Gateway is using a random port though unless specified otherwise.
The expected behavior is to respect user provided ports for the Gateway and use 8080 if there was no port specified.

My change fixes this in the Flow. Its fairly hacky/ugly, but I don't know how to do it differently really without breaking the parser. The main problem is that --port defaults to a random port, so its hard to check if the value was user set or just defaulted to. Thus I am using the kwargs in the Flow.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing labels Apr 12, 2022
@github-actions
Copy link

github-actions bot commented Apr 12, 2022

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1368, delta to last 2 avg.: +14%
  • 🐎🐎 query QPS at 73, delta to last 2 avg.: +7%
  • 🐢🐢 avg flow time within 0.9724 seconds, delta to last 2 avg.: -15%
  • 🐢🐢 import jina within 0.4123 seconds, delta to last 2 avg.: -7%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1368 73 0.9724 0.4123
3.3.0 1296 77 1.1445 0.4087
3.2.10 1089 58 1.1652 0.4849

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #4605 (5035415) into master (c342915) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4605      +/-   ##
==========================================
+ Coverage   84.38%   84.51%   +0.12%     
==========================================
  Files         117      117              
  Lines        8479     8484       +5     
==========================================
+ Hits         7155     7170      +15     
+ Misses       1324     1314      -10     
Flag Coverage Δ
jina 84.51% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 67.46% <100.00%> (-0.39%) ⬇️
jina/orchestrate/flow/base.py 87.42% <100.00%> (+4.60%) ⬆️
jina/helloworld/fashion/helper.py 0.00% <0.00%> (-93.27%) ⬇️
jina/helloworld/fashion/my_executors.py 0.00% <0.00%> (-90.48%) ⬇️
jina/helloworld/multimodal/app.py 0.00% <0.00%> (-88.14%) ⬇️
jina/helloworld/fashion/app.py 0.00% <0.00%> (-84.62%) ⬇️
jina/helloworld/multimodal/my_executors.py 69.79% <0.00%> (-27.52%) ⬇️
jina/parsers/helloworld.py 92.30% <0.00%> (-3.85%) ⬇️
jina/clients/base/grpc.py 76.36% <0.00%> (-1.82%) ⬇️
jina/orchestrate/deployments/config/helper.py 94.73% <0.00%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dac2150...5035415. Read the comment docs.

@jacobowitz jacobowitz requested a review from JoanFM April 12, 2022 15:39
@jacobowitz jacobowitz marked this pull request as ready for review April 12, 2022 15:39
@JoanFM JoanFM merged commit 929054e into master Apr 12, 2022
@JoanFM JoanFM deleted the fix-gateway-k8s-port branch April 12, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants