fix: 8080 as default gateway port in k8s #4605
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8080 as default gateway port in k8s
Description
In K8s all Pods should use 8080 as the default port (expect monitoring and uses_before/uses_after). At the moment the Gateway is using a random port though unless specified otherwise.
The expected behavior is to respect user provided ports for the Gateway and use 8080 if there was no port specified.
My change fixes this in the Flow. Its fairly hacky/ugly, but I don't know how to do it differently really without breaking the parser. The main problem is that --port defaults to a random port, so its hard to check if the value was user set or just defaulted to. Thus I am using the
kwargs
in the Flow.