fix: sandbox tls #4608
Merged
fix: sandbox tls #4608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/S
area/core
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
Codecov Report
@@ Coverage Diff @@
## master #4608 +/- ##
==========================================
- Coverage 87.72% 87.70% -0.03%
==========================================
Files 117 117
Lines 8484 8485 +1
==========================================
- Hits 7443 7442 -1
- Misses 1041 1043 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jacobowitz
commented
Apr 13, 2022
| available_services = GrpcConnectionPool.get_available_services(self.address) | ||
| async def _init_stubs(self): | ||
| available_services = await GrpcConnectionPool.get_available_services( | ||
| self.channel |
There was a problem hiding this comment.
this is the important change as we use the existing self.channel and not create a new one from address
mapleeit
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix gRPC reflection using TLS
Description
gRPC reflection is not respecting the TLS setttings. This makes all encrypted gRPC connections fail. This happens e.g. for sandbox.
This PR changes the logic so that we just reuse the existing channel for the reflection. This way I don't have to worry about the settings