Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix grpcio-reflection version #4715

Merged
merged 3 commits into from
Apr 28, 2022
Merged

fix: fix grpcio-reflection version #4715

merged 3 commits into from
Apr 28, 2022

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Apr 28, 2022

Goals:
Fix the conda recipe building

@github-actions github-actions bot added size/XS area/setup This issue/PR affects setting up Jina labels Apr 28, 2022
@github-actions
Copy link

github-actions bot commented Apr 28, 2022

Latency summary

Current PR yields:

  • 😶 index QPS at 1407, delta to last 2 avg.: +0%
  • 😶 query QPS at 74, delta to last 2 avg.: -4%
  • 🐎🐎 avg flow time within 1.5405 seconds, delta to last 2 avg.: +6%
  • 😶 import jina within 0.4614 seconds, delta to last 2 avg.: +5%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1407 74 1.5405 0.4614
3.3.17 1369 74 1.621 0.4381
3.3.16 1441 80 1.281 0.4395

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM closed this Apr 28, 2022
@JoanFM JoanFM reopened this Apr 28, 2022
@github-actions github-actions bot added area/core This issue/PR affects the core codebase component/resource labels Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #4715 (05b6efb) into master (917604d) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4715      +/-   ##
==========================================
- Coverage   87.84%   87.78%   -0.06%     
==========================================
  Files         119      119              
  Lines        8615     8615              
==========================================
- Hits         7568     7563       -5     
- Misses       1047     1052       +5     
Flag Coverage Δ
jina 87.78% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/orchestrate/deployments/config/docker_compose.py 99.00% <0.00%> (-1.00%) ⬇️
jina/orchestrate/flow/base.py 89.77% <0.00%> (-0.62%) ⬇️
jina/serve/runtimes/gateway/http/__init__.py 100.00% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 917604d...05b6efb. Read the comment docs.

@JoanFM JoanFM merged commit 07ae316 into master Apr 28, 2022
@JoanFM JoanFM deleted the fix-requirements-version branch April 28, 2022 10:56
@nan-wang
Copy link
Member

nan-wang commented Apr 29, 2022

Unpin the version restriction in #4650 .
This is an upstream issue and it is fixed. grpc/grpc#29044
The next release 1.46.0 will include this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/setup This issue/PR affects setting up Jina component/resource size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants