Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove version check from cli #4716

Merged
merged 3 commits into from
Apr 28, 2022
Merged

fix: remove version check from cli #4716

merged 3 commits into from
Apr 28, 2022

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Apr 28, 2022

No description provided.

@github-actions github-actions bot added size/XS area/cli This issue/PR affects the command line interface labels Apr 28, 2022
@github-actions
Copy link

github-actions bot commented Apr 28, 2022

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1025, delta to last 2 avg.: -23%
  • 🐢🐢 query QPS at 53, delta to last 2 avg.: -25%
  • 😶 avg flow time within 1.9973 seconds, delta to last 2 avg.: -3%
  • 🐎🐎🐎🐎 import jina within 0.6009 seconds, delta to last 2 avg.: +32%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1025 53 1.9973 0.6009
3.3.17 1341 70 2.8536 0.4477
3.3.16 1344 71 1.2906 0.457

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #4716 (4b9031f) into master (917604d) will decrease coverage by 0.06%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #4716      +/-   ##
==========================================
- Coverage   87.84%   87.77%   -0.07%     
==========================================
  Files         119      119              
  Lines        8615     8617       +2     
==========================================
- Hits         7568     7564       -4     
- Misses       1047     1053       +6     
Flag Coverage Δ
jina 87.77% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 65.51% <50.00%> (-0.37%) ⬇️
...a/orchestrate/deployments/config/docker_compose.py 99.00% <0.00%> (-1.00%) ⬇️
jina/orchestrate/flow/base.py 89.77% <0.00%> (-0.62%) ⬇️
jina/serve/runtimes/gateway/http/__init__.py 100.00% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 917604d...4b9031f. Read the comment docs.

@hanxiao
Copy link
Member

hanxiao commented Apr 28, 2022

btw this is the same as moving cli module completely under jina module, where the latter is tbh more clear

@JoanFM JoanFM requested a review from hanxiao as a code owner April 28, 2022 10:20
@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality labels Apr 28, 2022
@JoanFM JoanFM changed the title refactor: import jina on top of cli fix: remove version check Apr 28, 2022
@JoanFM JoanFM changed the title fix: remove version check fix: remove version check from cli Apr 28, 2022
@JoanFM JoanFM merged commit e57f952 into master Apr 28, 2022
@JoanFM JoanFM deleted the import-jina-cli-top branch April 28, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality size/M size/S size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants