Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional metrics #4789

Merged
merged 2 commits into from
May 19, 2022
Merged

feat: add additional metrics #4789

merged 2 commits into from
May 19, 2022

Conversation

samsja
Copy link
Contributor

@samsja samsja commented May 16, 2022

linked to #4731

add new metrics

  • Request size: In bytes of the request object
  • Number of pending requests: gateway only

SKIP

  • (skip to do in another PR) Number of fails: How many requests failed, exception type etc
  • (skip to do in another PR) Number of Clients connected: gateway only

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels May 16, 2022
@github-actions github-actions bot added the area/docs This issue/PR affects the docs label May 16, 2022
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #4789 (7357a9a) into master (f0f5948) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4789      +/-   ##
==========================================
+ Coverage   88.01%   88.26%   +0.24%     
==========================================
  Files         119      119              
  Lines        9012     9031      +19     
==========================================
+ Hits         7932     7971      +39     
+ Misses       1080     1060      -20     
Flag Coverage Δ
jina 88.26% <100.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/serve/runtimes/gateway/request_handling.py 96.29% <100.00%> (+0.21%) ⬆️
.../runtimes/request_handlers/data_request_handler.py 94.57% <100.00%> (+0.21%) ⬆️
...a/orchestrate/deployments/config/docker_compose.py 99.00% <0.00%> (-1.00%) ⬇️
jina/orchestrate/flow/base.py 89.56% <0.00%> (-0.48%) ⬇️
jina/helper.py 81.75% <0.00%> (+0.02%) ⬆️
jina/hubble/helper.py 89.29% <0.00%> (+1.29%) ⬆️
jina/serve/runtimes/gateway/http/__init__.py 100.00% <0.00%> (+2.22%) ⬆️
jina/types/mixin.py 72.91% <0.00%> (+4.16%) ⬆️
jina/orchestrate/deployments/__init__.py 91.14% <0.00%> (+4.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d85a5...7357a9a. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 16, 2022

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1513, delta to last 2 avg.: +47%
  • 🐎🐎🐎🐎 query QPS at 85, delta to last 2 avg.: +65%
  • 🐎🐎🐎🐎 avg flow time within 1.4864 seconds, delta to last 2 avg.: +11%
  • 🐢🐢 import jina within 0.41 seconds, delta to last 2 avg.: -29%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1513 85 1.4864 0.41
3.4.4 984 49 1.3694 0.6252
3.4.3 1073 53 1.2997 0.5425

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM linked an issue May 16, 2022 that may be closed by this pull request
4 tasks
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests should be added

@samsja samsja force-pushed the feat-new-metrics branch 3 times, most recently from 91b8156 to e2f347f Compare May 18, 2022 10:24
@github-actions github-actions bot added size/M area/testing This issue/PR affects testing labels May 18, 2022
@samsja
Copy link
Contributor Author

samsja commented May 18, 2022

Some tests should be added

I added integration tests for both of the current metrics

@github-actions
Copy link

📝 Docs are deployed on https://feat-new-metrics--jina-docs.netlify.app 🎉

@samsja samsja merged commit a9ed27e into master May 19, 2022
@samsja samsja deleted the feat-new-metrics branch May 19, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/testing This issue/PR affects testing epic/monitoring size/M size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement all the metrics that we want to expose post release
2 participants