Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qabot): hide the slot elements on the docs page #4799

Merged
merged 1 commit into from
May 18, 2022
Merged

Conversation

shazhou2015
Copy link
Member

Goals:
Add a template to prevent the qabot slot elements from showing on the docs pages.

@shazhou2015 shazhou2015 requested a review from nomagick May 18, 2022 10:20
@github-actions github-actions bot added size/S area/docs This issue/PR affects the docs labels May 18, 2022
@shazhou2015 shazhou2015 requested a review from JoanFM May 18, 2022 10:20
Copy link
Member

@nomagick nomagick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1146, delta to last 2 avg.: -4%
  • 😶 query QPS at 64, delta to last 2 avg.: +0%
  • 🐢🐢 avg flow time within 1.2851 seconds, delta to last 2 avg.: -25%
  • 🐎🐎 import jina within 0.5651 seconds, delta to last 2 avg.: +7%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1146 64 1.2851 0.5651
3.4.3 1342 73 1.5446 0.4527
3.4.2 1049 54 1.9285 0.6025

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit d66e98c into master May 18, 2022
@JoanFM JoanFM deleted the fix-qabot branch May 18, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs This issue/PR affects the docs size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants