Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unsetenv not existing on Windows #4800

Merged
merged 1 commit into from
May 18, 2022
Merged

fix: unsetenv not existing on Windows #4800

merged 1 commit into from
May 18, 2022

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented May 18, 2022

Goals:

  • ...
  • ...
  • check and update documentation. See guide and ask the team.

@JoanFM JoanFM linked an issue May 18, 2022 that may be closed by this pull request
@github-actions github-actions bot added size/XS area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality labels May 18, 2022
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #4800 (cfd7ef7) into master (a32bfe2) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4800      +/-   ##
==========================================
- Coverage   88.01%   87.96%   -0.06%     
==========================================
  Files         119      119              
  Lines        9012     9013       +1     
==========================================
- Hits         7932     7928       -4     
- Misses       1080     1085       +5     
Flag Coverage Δ
jina 87.96% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 65.88% <100.00%> (ø)
jina/helper.py 81.75% <100.00%> (+0.02%) ⬆️
...a/orchestrate/deployments/config/docker_compose.py 99.00% <0.00%> (-1.00%) ⬇️
jina/orchestrate/flow/base.py 89.45% <0.00%> (-0.59%) ⬇️
jina/serve/runtimes/gateway/http/__init__.py 100.00% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b5efac...cfd7ef7. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1324, delta to last 2 avg.: +0%
  • 😶 query QPS at 76, delta to last 2 avg.: +0%
  • 🐎🐎 avg flow time within 1.7995 seconds, delta to last 2 avg.: +10%
  • 🐎🐎 import jina within 0.4816 seconds, delta to last 2 avg.: +6%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1324 76 1.7995 0.4816
3.4.3 1347 79 1.4542 0.4475
3.4.2 1312 72 1.8056 0.46

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit 0372f10 into master May 18, 2022
@JoanFM JoanFM deleted the fix-cli-windows branch May 18, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jina new is not supported on Windows
1 participant