Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove executor secret from flow mermaid chart #4801

Merged
merged 1 commit into from
May 18, 2022

Conversation

delgermurun
Copy link
Contributor

@delgermurun delgermurun commented May 18, 2022

No description provided.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing labels May 18, 2022
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #4801 (bcf2a1a) into master (d66e98c) will increase coverage by 0.15%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #4801      +/-   ##
==========================================
+ Coverage   88.02%   88.18%   +0.15%     
==========================================
  Files         119      119              
  Lines        9012     9021       +9     
==========================================
+ Hits         7933     7955      +22     
+ Misses       1079     1066      -13     
Flag Coverage Δ
jina 88.18% <88.88%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/orchestrate/deployments/__init__.py 91.14% <80.00%> (+4.45%) ⬆️
jina/hubble/helper.py 88.31% <100.00%> (+0.31%) ⬆️
...a/orchestrate/deployments/config/docker_compose.py 99.00% <0.00%> (-1.00%) ⬇️
jina/orchestrate/flow/base.py 89.45% <0.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d66e98c...bcf2a1a. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1147, delta to last 2 avg.: -4%
  • 😶 query QPS at 63, delta to last 2 avg.: -1%
  • 🐢🐢 avg flow time within 1.3371 seconds, delta to last 2 avg.: -22%
  • 🐎🐎🐎🐎 import jina within 0.6007 seconds, delta to last 2 avg.: +19%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1147 63 1.3371 0.6007
3.4.3 1060 55 1.9005 0.5384
3.4.2 1342 71 1.566 0.4657

Backed by latency-tracking. Further commits will update this comment.

@delgermurun delgermurun marked this pull request as ready for review May 18, 2022 12:51
@JoanFM JoanFM merged commit 99ccff1 into master May 18, 2022
@JoanFM JoanFM deleted the fix-remove-executor-secret-from-diagram branch May 18, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants