Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decrement requests count in case of exception inside HeadRuntime #5383

Merged
merged 2 commits into from
Nov 11, 2022

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Nov 11, 2022

In case of some Exceptions, the count of pending requests and some stats related were not properly decremented

@JoanFM JoanFM linked an issue Nov 11, 2022 that may be closed by this pull request
@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase labels Nov 11, 2022
Copy link
Contributor

@girishc13 girishc13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please update the title and description.

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #5383 (9b8b714) into master (de53f95) will increase coverage by 0.10%.
The diff coverage is 98.12%.

@@            Coverage Diff             @@
##           master    #5383      +/-   ##
==========================================
+ Coverage   86.83%   86.94%   +0.10%     
==========================================
  Files         100      101       +1     
  Lines        6512     6611      +99     
==========================================
+ Hits         5655     5748      +93     
- Misses        857      863       +6     
Flag Coverage Δ
jina 86.94% <98.12%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/parsers/deprecated.py 83.33% <ø> (ø)
jina/parsers/orchestrate/pod.py 100.00% <ø> (ø)
jina/parsers/orchestrate/runtimes/head.py 100.00% <ø> (ø)
jina/parsers/orchestrate/runtimes/remote.py 100.00% <ø> (ø)
jina/parsers/orchestrate/runtimes/runtime.py 100.00% <ø> (ø)
jina/serve/streamer.py 95.91% <ø> (ø)
jina/serve/runtimes/head/request_handling.py 94.11% <94.11%> (ø)
jina/orchestrate/flow/base.py 90.77% <100.00%> (ø)
jina/parsers/orchestrate/runtimes/worker.py 100.00% <100.00%> (ø)
jina/serve/executors/decorators.py 98.71% <100.00%> (+0.18%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JoanFM JoanFM changed the title fix: decrement in case of exception fix: decrement requests count in case of exception inside HeadRuntime Nov 11, 2022
@JoanFM JoanFM merged commit babb04d into master Nov 11, 2022
@JoanFM JoanFM deleted the fix-update-on-exception branch November 11, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase size/S size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: MonitoringMixIn needs to correctly clear internal dict
2 participants