Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: decrement requests count in case of exception inside HeadRuntime #5383

Merged
merged 2 commits into from
Nov 11, 2022
Merged

fix: decrement requests count in case of exception inside HeadRuntime #5383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e5118c
fix: decrement in case of exception
JoanFM Nov 11, 2022
9b8b714
Merge branch 'master' into fix-update-on-exception
JoanFM Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions jina/serve/networking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,6 +1033,8 @@ async def task_wrapper():
)
if error:
return error
except Exception as e:
return e

return asyncio.create_task(task_wrapper())

Expand Down
1 change: 1 addition & 0 deletions jina/serve/runtimes/head/request_handling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ async def _handle_data_request(
retries=retries,
)
if issubclass(type(result), BaseException):
self._update_end_failed_requests_metrics()
raise result
else:
response_request, uses_after_metadata = result
Expand Down