-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support docarray v2 #5603
Conversation
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> wip Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> feat: compatible with docarray b2 Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
This reverts commit b8d5349.
8932dee
to
6b0c3cb
Compare
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Co-authored-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Co-authored-by: AlaeddineAbdessalem <alaeddine-13@live.fr>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things I missed on the first round
|
||
Jina provides early support for [DocArray v2](https://github.com/docarray/docarray/commits/feat-rewrite-v2) which | ||
is a rewrite of DocArray. DocArray v2 makes the dataclass feature of DocArray-v1 a first-class citizen and for this | ||
purpose it is built on top of [pydantic](https://pydantic-docs.helpmanual.io/) and . An important shift is that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and...what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or was this an editing glitch on my part from earlier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
euh yeah I think so ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay actually it is on the next line nothing wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
📝 Docs are deployed on https://feat-docarray-v2--jina-docs.netlify.app 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Hey coming here after reading this. Was wondering if the subtype approach that you implemented works well with TorchDynamo ? For context, I have a tuple that I wanna attach to my torch.Tensor and be able to slice my tensor based on the tuple inside torch.compile fullgraph=True. Was wondering if you hit on any sharp edges that would be good to know ? Thanks ! |
I did not try torch compile / torch dynamo related things with this approach. I would think that it is working |
Context
this PR is a PoC to support docarray v2 in jina.
This pr make jina compatible with v2 while keeping v1 support as well.
PS: Some of the features are yet not compatible with v2, like filtering etc, but this is an entry point for letting people play with v2.
what this pr do
allow to do
FastAPI: