docs(jcloud): add storage section #5831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcg1
requested changes
Apr 25, 2023
Comment on lines
231
to
234
| | min | 1 | int | Minimum number of replicas (`0` means serverless) | | ||
| | max | 2 | int, up to 5 | Maximum number of replicas | | ||
| | metric | concurrency | `concurrency` / `rps` | Metric for scaling | | ||
| | target | 100 | int | Target value of `metric` after which replicas autoscale | |
There was a problem hiding this comment.
some stuff should likely be wrapped in backticks here?
There was a problem hiding this comment.
Could you be more specific here @alexcg1 which parts should be wrapped?
alexcg1
requested changes
Apr 27, 2023
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
|
📝 Docs are deployed on https://docs-jcloud-storage--jina-docs.netlify.app 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals:
Fixes naming for components in
jcloudAdds missing
storagesectionFixes description of
targetin autoscalingcheck and update documentation. See guide and ask the team.