fix: remove outdated protobuf that caused notebook crash #5888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex C-G <alexcg@outlook.com>
github-actions
bot
added
size/XS
area/housekeeping
JoanFM
approved these changes
May 22, 2023
Codecov Report
@@ Coverage Diff @@
## master #5888 +/- ##
==========================================
- Coverage 80.65% 75.52% -5.14%
==========================================
Files 142 140 -2
Lines 12145 12099 -46
==========================================
- Hits 9796 9138 -658
- Misses 2349 2961 +612
Flags with carried forward coverage won't be shown. Click here to find out more. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notebook was crashing due to a pinned version of protobuf (that we initially used as a workaround for a different bug).
That caused it to crash with the current version of Jina. Removing the pinned version fixes that crash