Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove aiostream dependency #5891

Merged
merged 1 commit into from
May 23, 2023
Merged

chore: remove aiostream dependency #5891

merged 1 commit into from
May 23, 2023

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented May 23, 2023

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/setup This issue/PR affects setting up Jina component/client labels May 23, 2023
alaeddine-13
alaeddine-13 previously approved these changes May 23, 2023
@JoanFM JoanFM linked an issue May 23, 2023 that may be closed by this pull request
@JoanFM JoanFM force-pushed the chore-remove-aiostream branch 2 times, most recently from 7c39836 to 4d30740 Compare May 23, 2023 08:40
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #5891 (24393c9) into master (7d2d116) will decrease coverage by 1.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5891      +/-   ##
==========================================
- Coverage   80.65%   79.57%   -1.09%     
==========================================
  Files         142      142              
  Lines       12145    12148       +3     
==========================================
- Hits         9796     9667     -129     
- Misses       2349     2481     +132     
Flag Coverage Δ
jina 79.57% <100.00%> (-1.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/clients/request/asyncio.py 80.00% <100.00%> (-20.00%) ⬇️
jina/serve/stream/__init__.py 98.51% <100.00%> (-0.02%) ⬇️

... and 28 files with indirect coverage changes

Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
@JoanFM JoanFM merged commit 5451f55 into master May 23, 2023
@JoanFM JoanFM deleted the chore-remove-aiostream branch May 23, 2023 09:50
@JoanFM JoanFM mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/setup This issue/PR affects setting up Jina component/client component/resource size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License problem!
2 participants