Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix check graph compatibility nested types #6085

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Oct 15, 2023

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@JoanFM JoanFM linked an issue Oct 15, 2023 that may be closed by this pull request
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing labels Oct 15, 2023
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (496041e) 76.91% compared to head (2e60eb4) 76.86%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6085      +/-   ##
==========================================
- Coverage   76.91%   76.86%   -0.05%     
==========================================
  Files         145      145              
  Lines       13989    13991       +2     
==========================================
- Hits        10759    10754       -5     
- Misses       3230     3237       +7     
Flag Coverage Δ
jina 76.86% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ina/serve/runtimes/gateway/graph/topology_graph.py 69.55% <0.00%> (-0.37%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM JoanFM merged commit c76d9ab into master Oct 18, 2023
125 of 129 checks passed
@JoanFM JoanFM deleted the fix-issue-6084 branch October 18, 2023 04:46
@JoanFM JoanFM mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topology graph Key Error (After Jina 3.21.0)
1 participant