Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix subclass with DocList #6138

Merged
merged 3 commits into from
Feb 15, 2024
Merged

fix: fix subclass with DocList #6138

merged 3 commits into from
Feb 15, 2024

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Feb 15, 2024

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@JoanFM JoanFM marked this pull request as draft February 15, 2024 20:41
@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase labels Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (be263b1) 75.06% compared to head (ef736a1) 75.21%.
Report is 1 commits behind head on master.

Files Patch % Lines
jina/serve/runtimes/helper.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6138      +/-   ##
==========================================
+ Coverage   75.06%   75.21%   +0.15%     
==========================================
  Files         152      152              
  Lines       14061    14062       +1     
==========================================
+ Hits        10555    10577      +22     
+ Misses       3506     3485      -21     
Flag Coverage Δ
jina 75.21% <0.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM JoanFM linked an issue Feb 15, 2024 that may be closed by this pull request
@github-actions github-actions bot added size/S area/testing This issue/PR affects testing labels Feb 15, 2024
@JoanFM JoanFM force-pushed the fix-6137 branch 3 times, most recently from bdf212e to 623e177 Compare February 15, 2024 21:01
@JoanFM JoanFM marked this pull request as ready for review February 15, 2024 21:02
Signed-off-by: Joan Martinez <joan.fontanals.martinez@jina.ai>
Signed-off-by: Joan Martinez <joan.fontanals.martinez@jina.ai>
@JoanFM JoanFM merged commit 073511e into master Feb 15, 2024
130 of 133 checks passed
@JoanFM JoanFM deleted the fix-6137 branch February 15, 2024 22:46
@JoanFM JoanFM mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing size/S size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot serialize subfield objects properly
1 participant