Skip to content

Commit

Permalink
Remove more traces of core magit package (kubernetes-el#182)
Browse files Browse the repository at this point in the history
Partially addresses #2.

This PR replaces the `magit-branch-remote` and `magit-tag` parent
faces with their literal counterparts. I believe this is the last of
the faces inherited from Magit proper.

Incidentally, this PR also replaces some `require`s of `magit` in
packages that only use `magit-section` constructs with
`magit-section`, helping to further remove dependency on Magit proper.
  • Loading branch information
jinnovation committed Jul 7, 2021
1 parent 29baa96 commit 0cb1e26
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
1 change: 0 additions & 1 deletion kubernetes-ast.el
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
;;; Code:

(require 'cl-lib)
(require 'magit)
(require 'magit-section)
(require 'subr-x)

Expand Down
1 change: 1 addition & 0 deletions kubernetes-ingress.el
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
(require 'kubernetes-state)
(require 'kubernetes-utils)
(require 'kubernetes-yaml)
(require 'magit-section)


;; Components
Expand Down
2 changes: 1 addition & 1 deletion kubernetes-modes.el
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
;;; Commentary:
;;; Code:

(require 'magit)
(require 'magit-section)
(require 'subr-x)

(autoload 'kubernetes-config-popup "kubernetes-popups")
Expand Down
4 changes: 2 additions & 2 deletions kubernetes-vars.el
Original file line number Diff line number Diff line change
Expand Up @@ -168,12 +168,12 @@ form \"--flag=value\" or \"-flag\"."
:group 'kubernetes)

(defface kubernetes-selector
'((t :inherit magit-branch-remote))
'((t :foreground "DarkSeaGreen2"))
"Face for labels used as selectors."
:group 'kubernetes)

(defface kubernetes-namespace
'((t :inherit magit-tag))
'((t :foreground "LightGoldenrod2"))
"Face for namespace references."
:group 'kubernetes)

Expand Down

0 comments on commit 0cb1e26

Please sign in to comment.