Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move RegEx to JSON #8

Closed
Jithinqw opened this issue Jun 19, 2019 · 1 comment
Closed

Move RegEx to JSON #8

Jithinqw opened this issue Jun 19, 2019 · 1 comment

Comments

@Jithinqw
Copy link
Owner

Jithinqw commented Jun 19, 2019 •
edited
Loading

Since we have implemented most of the things as a JSON file. It's a better way to move
regular expression defined in isPhoneNumber to a JSON file!
@Jithinqw Jithinqw changed the title As most Move RegEx to JSON Jun 19, 2019
@Jithinqw
Copy link
Owner Author

Jithinqw commented Aug 6, 2019

Moving to RegEx is a good thing, because this has more performance in JSPerf. We will move to RegEx on next release.

@Jithinqw Jithinqw closed this as completed Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jithinqw