Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request to fix issue 244 #245

Closed
wants to merge 2 commits into from
Closed

Pull request to fix issue 244 #245

wants to merge 2 commits into from

Conversation

indiscrete-void
Copy link

@indiscrete-void indiscrete-void commented Nov 28, 2021

I added guard code for case when provided length is zero in PseudoTcpInputStream#read

Idk if guard code from length == 0 should be placed on lower level than PseudoTcpInputStream#read, it's for you to decide if it should be in PseudoTCPBase#recv (or lower)

Made #read(byte[], int, int) return 0 if given length to read is 0
(fixes #244)
@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #245 (e9fb5ef) into master (64a7ca8) will increase coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #245      +/-   ##
============================================
+ Coverage     38.60%   38.75%   +0.15%     
- Complexity     1351     1352       +1     
============================================
  Files           178      178              
  Lines         12142    12144       +2     
  Branches       1836     1837       +1     
============================================
+ Hits           4688     4707      +19     
+ Misses         6802     6779      -23     
- Partials        652      658       +6     
Impacted Files Coverage Δ
.../java/org/ice4j/pseudotcp/PseudoTcpSocketImpl.java 65.32% <0.00%> (-0.09%) ⬇️
...in/java/org/ice4j/ice/ConnectivityCheckClient.java 55.62% <0.00%> (-2.44%) ⬇️
...in/java/org/ice4j/stack/StunClientTransaction.java 81.55% <0.00%> (-1.95%) ⬇️
src/main/java/org/ice4j/ice/CandidatePair.java 67.91% <0.00%> (-1.50%) ⬇️
src/main/java/org/ice4j/message/Message.java 49.81% <0.00%> (-0.74%) ⬇️
...c/main/java/org/ice4j/pseudotcp/PseudoTCPBase.java 64.00% <0.00%> (+0.15%) ⬆️
...org/ice4j/socket/MultiplexingXXXSocketSupport.java 52.12% <0.00%> (+0.60%) ⬆️
src/main/java/org/ice4j/ice/Agent.java 56.08% <0.00%> (+1.28%) ⬆️
src/main/java/org/ice4j/util/PeriodicRunnable.java 75.75% <0.00%> (+1.51%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64a7ca8...e9fb5ef. Read the comment docs.

@indiscrete-void indiscrete-void closed this by deleting the head repository Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants