Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix error message when a jibri session already exists. #826

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Nov 4, 2021

No description provided.

@bgrozev
Copy link
Member Author

bgrozev commented Nov 4, 2021

This changes the error condition, so it will be rendered differently in jitsi-meet. I think that's fine, as it's either a rare race condition or a bug in the client. Any thoughts @saghul (see JID-8726 for more context)

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #826 (c4492fb) into master (931b95a) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #826      +/-   ##
============================================
- Coverage     44.90%   44.70%   -0.20%     
+ Complexity      756      750       -6     
============================================
  Files           111      111              
  Lines          6527     6527              
  Branches        920      920              
============================================
- Hits           2931     2918      -13     
- Misses         3188     3195       +7     
- Partials        408      414       +6     
Impacted Files Coverage Δ
...rc/main/kotlin/org/jitsi/jicofo/jibri/BaseJibri.kt 0.00% <0.00%> (ø)
...si/jicofo/conference/AbstractChannelAllocator.java 39.08% <0.00%> (-3.45%) ⬇️
...itsi/protocol/xmpp/AbstractOperationSetJingle.java 54.18% <0.00%> (-1.68%) ⬇️
...tsi/jicofo/conference/JitsiMeetConferenceImpl.java 43.70% <0.00%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 931b95a...c4492fb. Read the comment docs.

@bgrozev bgrozev merged commit 010cfcc into jitsi:master Nov 5, 2021
@bgrozev bgrozev deleted the fix-jibri-request-while-recording branch January 25, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants