Refactor colibri handling in JitsiMeetConferenceImpl. #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #843 +/- ##
============================================
- Coverage 45.82% 45.45% -0.38%
- Complexity 785 788 +3
============================================
Files 112 115 +3
Lines 6965 7078 +113
Branches 968 970 +2
============================================
+ Hits 3192 3217 +25
- Misses 3346 3445 +99
+ Partials 427 416 -11
Continue to review full report at Codecov.
|
src/main/java/org/jitsi/jicofo/conference/JitsiMeetConferenceImpl.java
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/jitsi/jicofo/conference/ColibriSessionManager.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/jitsi/jicofo/conference/ColibriSessionManager.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/jitsi/jicofo/conference/ColibriSessionManager.kt
Outdated
Show resolved
Hide resolved
| /** | ||
| * Get a stream of those bridges which are operational. | ||
| */ | ||
| private fun operationalBridges(): List<BridgeSession> = synchronized(syncRoot) { |
There was a problem hiding this comment.
I think this is always called from inside synchronized(syncRoot) so you shouldn't need to synchronize again.
There was a problem hiding this comment.
I'd rather aquire the lock twice, the performance impact should be minimal.
src/main/kotlin/org/jitsi/jicofo/conference/ColibriSessionManager.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/jitsi/jicofo/conference/ColibriSessionManager.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/jitsi/jicofo/conference/colibri/ColibriSessionManager.kt
Show resolved
Hide resolved
…colibri request success/failure.
This state is already updated via BridgeSession.colibriConference.muteParticipant
src/main/kotlin/org/jitsi/jicofo/conference/colibri/ColibriSessionManager.kt
Outdated
Show resolved
Hide resolved
bgrozev
changed the title
src/main/kotlin/org/jitsi/jicofo/conference/colibri/ColibriSessionManager.kt
Outdated
Show resolved
Hide resolved
JonathanLennox
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to abstract away all the colibri-related logic in JitsiMeetConferenceImpl, so that it can later be replaced with a colibri2 implementation.