-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conference video quality drops when a user is on an Electron window #14396
Comments
Which version of electron is that? |
Electron 22, but I tested it even on Electron 27, and happened too. The video shared makes it unreadable when the Electron window enters the call. There is any limitations on the version known for this? |
Can you check what is the tile height thats calculated on the electron client? The log should look something like this
For example, in this case, the height of each of the tiles is 587.5 pixels, so the client is going to request the bridge to send 360p videos. Only if the calculated height >= 720, the client will request 720p videos from the bridge as seen in the below log.
|
We have the same problem on our site. How can I check this in the electron client ? |
You can enable developer tools and check in the console tab. |
Sorry for the late reply, I got sick last week. |
This will show on the console as the new users enter the call? |
It will show up with layout changes. |
There isnt any log with |
Chrome Screen sharer console log: Chrome viewer console log: Electron viewer console log: |
Did you make window size changes, for example? |
We did the following change from: |
Not it isn't. How big is your window and are you resizing it at runtime? |
We are always working in fullscreen mode. The application window is I think around 800x600 at the beginning. That is the standard size. And we normally resize it to fullscreen. |
Then you should see the messages @jallamsetty1 mentioned in the console logs. |
Perhaps @jeanfbrito can test this. He is the developer at RocketChat. |
Can you please share the full log from the screen sharer? I see the logs only upto the moment when the electron client joined and nothing after so it is hard to tell if having the electron client in the call changed the sender characteristics. Please share the full log for both the sender and the electron clien. |
I cannot open the developer tools (CTRL SHIFT I or F12) in the application window. Please tell me how to do this easily. It doesn't make sense to do this in the browser, because the problem doesn't appear there. |
Are you saying that you are seeing the share blurry only on the electron client? If everyone in the call is seeing the share blurry as soon as the electron client joins the call then the problem should be on the sender. |
Yes. Not only is the sharing blurred, but also the participants are all displayed with too low a resolution. Mostly in 180p. |
No because I was using fullscreen windows for testing, something near 1440p height. |
It was my intention, let me do again, maybe I cleaned up before entering with other clients. |
I can't see here any progress. The RocketChat users are waiting for a solution. |
You can also try to repro with our Electron app, though we haven't received any reports like this one... |
Here are all the logs from the screen sharer since the start until I close the Electron window. Resized the window on Electron, other windows was very big already. |
Until we found whats going on you can ask the users to open the calls inside web browser. Dont seems to be nothing that we changed from our side. |
Screen.Recording.2024-03-27.at.4.29.23.PM.movHere is the degradation that users are reporting. You can see that I open the Electron window. Even resizing it dont changes, if I close the Electron window it maintains that quality. I sent the screen sharer logs for this video. I kept it very small so I could attach here, if needed I can record more. https://github.com/jitsi/jitsi-meet/assets/1177482/a64f33f8-7372-4ce3-ac37-193d10af7407 |
I honestly don't know. Since it doesn't seem to reproduce with the Jitsi Meet app targeting meet.jit.si it could be an issue of the deployment. I'd say it's unlikely to be related to Electron itself, but I'm not 100% sure. |
It appears that you are running a very old version of the client that has source-name signaling and multi-stream mode disabled. We have made them the default behavior long time back and the backwards compat code has been removed from the bridge already. Are the client and backend versions out of sync by any chance? If you are running the older versions of both client and backend and the issue started happening recently then it could be something in your application or settings. |
This can be the issue, there is any console command that I can run to see the versions? |
Filter console logs with word version |
Only one is this:
This is the frontend version @damencho ? |
Nope this is jicofo, part of backend that was released on 17-Jun-2022. For The frontend you need to check the index.html source there are several places with v= which match the jitsi-meet-web version |
In our environment the version is |
Which is from 20-Dec-2023. Your frontend and backend are not compatible with each other. Not sure how you managed to update the packages with such a combination. |
What does that mean now ? |
As mentioned by @jallamsetty1 it can be the settings passed to the jitsi-meet client. Can you extract from the electron window the settings that are passed to the iframe that loads jitsi-meet? |
No, sorry, I can't. But @jeanfbrito can do perhaps. He is the developer of the RocketChat Electron. |
On electron side we don't add any settings, we just open the URL on a new window. But I'm reaching the people who maintain the Jitsi app on the Marketplace so we can update it and see what's going on. |
But the Jitsi app is also needed when the web browser is used for video calls. Or am I wrong ? |
Both load the same web app, it is just when loading with iframeAPI config overrides are done, I was thinking about those. |
I was looking for this now: |
It's in the JS console logs. |
Still can't find it. Can you show me in a screenshot or screencast ? |
It should show very early when the iframe was loaded. |
Can't see any [FeatureFlags] ... |
That log line was removed when we changed the defaults. What lib-jitsi-meet version are you seeing? The log should look like this:
|
|
This client version is from Dec 2023 and your backend is from Jun 2022. They are not compatible. The client logs @jeanfbrito shared doesn't have the above log line but instead prints the old log that has since been removed. Something is wrong with the client versions, sometimes the new version gets loaded and its the older one at other times. |
We updated yesterday Jitsi Meet to version 2.0.9364 and RocketChat to version 6.7.0. |
Did you update all components? Do you observe the problem now? |
What do you mean with all components ? |
That's what I meant: the frontend, jicofo and the jvb. |
BTW, the problem seems to be solved after the updates. Just had a meeting with 15 users and the quality is back to normal. |
Good to hear! I'm going to go ahead and close this then. |
Description:
Hello, I work on Rocket.Chat and we are having some users reporting an issue with Jitsi.
On our Desktop app we open Jitsi inside a new Electron window.
In a conference (a meeting with more than 2 users) when a user is inside our Desktop App, the quality is dropped of video sharing for everyone.
I tried investigating what we could do to fix that, but doesn't seem to be something from our side.
On the console log, I could find that when an Electron client is connected the
ReceiverVideoConstraints
is set to"maxHeight":360
.There is any way we can change this? The only way today is to make the video call open on the browser.
Steps to reproduce:
Expected behavior:
Work on Electron as it works on Chrome, if possible.
Actual behavior:
The video quality is dropped to 360p.
Server information:
Client information:
Additional information:
The text was updated successfully, but these errors were encountered: