Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bcprov-jdk15on to 1.54 #123

Merged
merged 1 commit into from
Apr 6, 2016
Merged

Conversation

champtar
Copy link
Contributor

@champtar champtar commented Jan 8, 2016

Quickly run tested with Firefox Nightly 46 and Chrome 47

Signed-off-by: Etienne CHAMPETIER champetier.etienne@gmail.com

@champtar champtar force-pushed the bcprov-jdk15on branch 3 times, most recently from 8660475 to 428b8fd Compare January 27, 2016 10:42
@champtar champtar force-pushed the bcprov-jdk15on branch 2 times, most recently from ec9fe3f to 5dffd37 Compare February 4, 2016 10:32
Quickly run tested with Firefox Nightly 46 and Chrome 47

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
@jitsi-jenkins
Copy link

Can one of the admins verify this patch?

@lyubomir lyubomir self-assigned this Apr 4, 2016
@lyubomir
Copy link
Contributor

lyubomir commented Apr 4, 2016

Jenkins: it's ok to test.

@ibauersachs
Copy link
Member

Note: this would be obsoleted by jitsi/jitsi-universe#5, or rather the version should be removed completely again.

@lyubomir
Copy link
Contributor

lyubomir commented Apr 4, 2016

Oh, thank you very much, @ibauersachs! Are you saying that I should merge your PR, then close this one, and remove the bouncycastle dependency from jitsi-videobridge?

@ibauersachs
Copy link
Member

@lyubomir Please do in the following order:

  1. merge the ice4j PRs. If that is done, I'll publish ice4j 1.0 on Maven Central.
  2. merge jitsi-universe#5
  3. set ice4j to version 1.0 in jitsi-universe (I can create a follow-up PR for that)
  4. update the pinned version of jitsi-universe in libjitsi. Include changes of Update boncycastle from 1.51 to 1.54 libjitsi#72 (except the fixed 1.54 version of BC) to enable compilation again.
  5. update the pinned version of jitsi-universe and libjitsi in videobridge and remove the BouncyCastle version (not the dependency).
  6. Do the same as in 5 for jicofo, maybe jigasi (haven't looked at that)

@lyubomir
Copy link
Contributor

lyubomir commented Apr 4, 2016

Thank you, @ibauersachs! I'll try to do as you said.

@ibauersachs
Copy link
Member

@lyubomir Thanks! I updated the comment before to include libjitsi updates.

@lyubomir lyubomir merged commit 85b498d into jitsi:master Apr 6, 2016
@champtar champtar deleted the bcprov-jdk15on branch April 6, 2016 08:33
bbaldino pushed a commit to bbaldino/jitsi-videobridge that referenced this pull request Jan 22, 2020
)

This eliminates a dependency on (deprecated) libjitsi RTPUtils.
bbaldino pushed a commit to bbaldino/jitsi-videobridge that referenced this pull request Sep 24, 2020
)

This eliminates a dependency on (deprecated) libjitsi RTPUtils.
JonathanLennox added a commit to JonathanLennox/jitsi-videobridge that referenced this pull request Jun 1, 2022
)

This eliminates a dependency on (deprecated) libjitsi RTPUtils.
This was referenced Jul 15, 2022
@bgrozev bgrozev mentioned this pull request Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants