Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a stat for endpoints with suspended sources. #1910

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Jun 9, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1910 (dc56442) into master (eec0775) will decrease coverage by 0.00%.
The diff coverage is 45.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1910      +/-   ##
============================================
- Coverage     40.96%   40.96%   -0.01%     
- Complexity     1707     1709       +2     
============================================
  Files           336      336              
  Lines         17428    17437       +9     
  Branches       2322     2325       +3     
============================================
+ Hits           7140     7143       +3     
- Misses         9595     9601       +6     
  Partials        693      693              
Impacted Files Coverage Δ
...jitsi/videobridge/stats/VideobridgeStatistics.java 0.32% <0.00%> (-0.01%) ⬇️
.../src/main/kotlin/org/jitsi/videobridge/Endpoint.kt 19.74% <0.00%> (-0.04%) ⬇️
...tsi/videobridge/cc/allocation/BitrateController.kt 57.04% <0.00%> (-0.41%) ⬇️
.../videobridge/cc/allocation/BandwidthAllocator.java 86.11% <100.00%> (ø)
...i/videobridge/cc/allocation/BandwidthAllocation.kt 89.36% <100.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec0775...dc56442. Read the comment docs.

Copy link
Member

@JonathanLennox JonathanLennox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add this to BandwidthAllocation's debugState?

@bgrozev bgrozev merged commit 3c9d3c5 into jitsi:master Jun 9, 2022
This was referenced Jul 15, 2022
@bgrozev bgrozev mentioned this pull request Jul 25, 2022
@bgrozev bgrozev deleted the suspended-stats branch May 23, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants