Fix for NPE in simulcast receiver. #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanLennox
pushed a commit
to JonathanLennox/jitsi-videobridge
that referenced
this pull request
Jun 1, 2022
* use atomicreference for writer handle * get rid of FeatureToggleEvent * rename variable * add getter to expose current state * make variable private * fix feature setting from transceiver to rtpreceiver/sender * expose api to get endpoint feature state * add missing call to close * revert back to using lock for pcapWriter
This was referenced Jun 3, 2022
This was referenced Jul 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
245ed9d introduces an NPE under certain occasions. This commit fixes it.