fix: Request keyframes from last-n endpoints for newly joined video channels #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As users join a meeting with last-n enabled they need to request keyframes from the currently forwarded endpoints in order to begin receiving video.
|
Hi, thanks for your contribution! |
|
@dazaar we have rewritten the lastN implementation and this should be fixed now as part of that. |
|
(Please open an issue or a new PR if this is still broken for you.) |
bgrozev
added a commit
to bgrozev/jitsi-videobridge
that referenced
this pull request
Nov 17, 2021
* fix: Use the clock instead of System.currentTimeMillis. (jitsi#380) * fix: Fix accessing stats for RR generation. (jitsi#381) * ref: Keep VideoParser stats in a class. * feat: Expose VideoParser stats via TransceiverStats, reorganize. * feat: Keep track of "active duration" per SSRC. * feat: Add mediaType to IncomingSsrcStats.
bgrozev
added a commit
that referenced
this pull request
Nov 17, 2021
… video stream duration. (#1762) * chore: Update JMT * fix: Use the clock instead of System.currentTimeMillis. (#380) * fix: Fix accessing stats for RR generation. (#381) * ref: Keep VideoParser stats in a class. * feat: Expose VideoParser stats via TransceiverStats, reorganize. * feat: Keep track of "active duration" per SSRC. * feat: Add mediaType to IncomingSsrcStats. * chore: Adapt to JMT API changes. * feat: Keep track of the number of received keyframes, layering changes, and video stream duration.
JonathanLennox
pushed a commit
to JonathanLennox/jitsi-videobridge
that referenced
this pull request
Jun 1, 2022
This was referenced Jun 3, 2022
This was referenced Jul 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As users join a meeting with last-n enabled they need to request
keyframes from the currently forwarded endpoints in order to
begin receiving video. Prior to this change a user joining the
meeting, that did not result in an update to the last-n endpoints,
would not receive keyframes for the forwarded endpoints. The
result was the newly joined user being unable to display video
until a dominant speaker event, pinned endpoint event, or
the next keyframe interval occurred.